don't throw an exception for unsupported statements

Author: zacMode

src/parse_tables.cpp

@@ -155,8 +155,6 @@ static void ExtractTablesFromSQL(const std::string &sql, std::vector<TableRefRes
             if (select_stmt.node) {
                 ExtractTablesFromQueryNode(*select_stmt.node, results);
             }
-        } else {
-            throw InvalidInputException("parse_tables only supports SELECT statements");        
         }
     }
 }
@@ -225,9 +223,7 @@ static void ParseTablesScalarFunction(DataChunk &args, ExpressionState &state, V
         auto query_string = query.GetString();
         std::vector<TableRefResult> parsed_tables;
         if (exclude_cte) {
-            std::unordered_set<std::string> excluded_types;
-            excluded_types.insert("cte");
-            excluded_types.insert("from_cte");
+            std::unordered_set<std::string> excluded_types = {"cte", "from_cte"};
             ExtractTablesFromSQL(query_string, parsed_tables, excluded_types);
         } else {
             ExtractTablesFromSQL(query_string, parsed_tables);

test/sql/parse_tools/scalar_functions/parse_table_names.test

@@ -32,4 +32,43 @@ SELECT parse_table_names('with cte_test as(select 1) select * from MyTable, cte_
 query I
 SELECT parse_table_names('with cte_test as(select 1) select * from MyTable, cte_test', false);
 ----
-[cte_test, MyTable, cte_test]
+[cte_test, MyTable, cte_test]
+
+# Unsupported 
+# -----------
+
+# INSERT INTO ... SELECT
+query I
+select parse_table_names('INSERT INTO m SELECT * FROM n;');
+----
+[]
+
+# UPDATE with FROM
+query I
+select parse_table_names('UPDATE o SET x = p.x FROM p WHERE o.id = p.id;');
+----
+[]
+
+# DELETE with USING
+query I
+select parse_table_names('DELETE FROM q USING r WHERE q.id = r.id;');
+----
+[]
+
+# CREATE VIEW AS SELECT
+query I
+select parse_table_names('CREATE VIEW v AS SELECT * FROM s JOIN t ON s.id = t.id;');
+----
+[]
+
+# CREATE TABLE AS SELECT
+query I
+select parse_table_names('CREATE TABLE u AS SELECT * FROM v;');
+----
+[]
+
+# no tables
+query I
+select parse_table_names('SELECT 1;');
+----
+[]

test/sql/parse_tools/scalar_functions/parse_tables.test

@@ -28,3 +28,43 @@ query I
 SELECT list_filter(parse_tables('select * from MyTable t inner join Other o on o.id = t.id'),t -> t.context = 'from') AS filtered_tables;
 ----
 [{'schema': main, 'table': MyTable, 'context': from}]
+
+
+# Unsupported 
+# -----------
+
+# INSERT INTO ... SELECT
+query I
+select parse_tables('INSERT INTO m SELECT * FROM n;');
+----
+[]
+
+# UPDATE with FROM
+query I
+select parse_tables('UPDATE o SET x = p.x FROM p WHERE o.id = p.id;');
+----
+[]
+
+# DELETE with USING
+query I
+select parse_tables('DELETE FROM q USING r WHERE q.id = r.id;');
+----
+[]
+
+# CREATE VIEW AS SELECT
+query I
+select parse_tables('CREATE VIEW v AS SELECT * FROM s JOIN t ON s.id = t.id;');
+----
+[]
+
+# CREATE TABLE AS SELECT
+query I
+select parse_tables('CREATE TABLE u AS SELECT * FROM v;');
+----
+[]
+
+# no tables
+query I
+select parse_tables('SELECT 1;');
+----
+[]

test/sql/parse_tools/table_functions/parse_tables.test

@@ -81,34 +81,29 @@ main	k	from
 main	l	from
 
 # INSERT INTO ... SELECT
-statement error
+query III
 SELECT * FROM parse_tables('INSERT INTO m SELECT * FROM n;');
 ----
-parse_tables only supports SELECT statements
 
 # UPDATE with FROM
-statement error
+query III
 SELECT * FROM parse_tables('UPDATE o SET x = p.x FROM p WHERE o.id = p.id;');
 ----
-parse_tables only supports SELECT statements
 
 # DELETE with USING
-statement error
+query III
 SELECT * FROM parse_tables('DELETE FROM q USING r WHERE q.id = r.id;');
 ----
-parse_tables only supports SELECT statements
 
 # CREATE VIEW AS SELECT
-statement error
+query III
 SELECT * FROM parse_tables('CREATE VIEW v AS SELECT * FROM s JOIN t ON s.id = t.id;');
 ----
-parse_tables only supports SELECT statements
 
 # CREATE TABLE AS SELECT
-statement error
+query III
 SELECT * FROM parse_tables('CREATE TABLE u AS SELECT * FROM v;');
 ----
-parse_tables only supports SELECT statements
 
 # no tables
 query III