Fix bug at end of buffer

Author: howardjohn

cmd/cmd.go

@@ -20,8 +20,9 @@ var (
 )
 
 var rootCmd = &cobra.Command{
-	Use:   "kubectl-grep",
-	Short: "A plugin to grep Kubernetes resources.",
+	Use:          "kubectl-grep",
+	Short:        "A plugin to grep Kubernetes resources.",
+	SilenceUsage: true,
 	RunE: func(cmd *cobra.Command, args []string) error {
 		dm := pkg.Full
 		if summary {

pkg/decode.go

@@ -55,16 +55,22 @@ func (r *YAMLReader) Read() ([]byte, error) {
 					return nil, err
 				}
 				if rr[0] == '-' {
+					// We hit the next entry
 					return buffer.Bytes(), nil
 				}
 				if rr[0] != ' ' {
+					// Not part of the list anymore, just be end of the list
+					// Drain the list so we don't read more
 					if _, err := io.Copy(io.Discard, r.reader.reader); err != nil {
 						return nil, err
 					}
 					return buffer.Bytes(), nil
 				}
 			}
-			_, _ = r.reader.reader.Read(listDiscard)
+			_, err := io.ReadFull(r.reader.reader, listDiscard)
+			if err != nil {
+				return nil, err
+			}
 			firstLoop = false
 		}
 

pkg/grep.go

@@ -139,7 +139,7 @@ func GrepResources(sel Selector, in io.Reader, out io.Writer, mode DisplayMode)
 		}
 		obj := KubernetesObject{}
 		if err := yaml.Unmarshal(text, &obj); err != nil {
-			return fmt.Errorf("failed to unmarshal yaml (%v): %v", text, err)
+			return fmt.Errorf("failed to unmarshal yaml (%v): %v", string(text), err)
 		}
 		if obj.MatchesAny(sel, text) {
 			if mode == Summary {