Merge pull request #822 from m5tfi/main

fixes #821: remove #[allow[clippy::from_over_into] and change to From

Author: Fishrock123

src/redirect.rs

@@ -96,18 +96,16 @@ where
     }
 }
 
-#[allow(clippy::from_over_into)]
-impl<T: AsRef<str>> Into<Response> for Redirect<T> {
-    fn into(self) -> Response {
-        (&self).into()
+impl<T: AsRef<str>> From<Redirect<T>> for Response {
+    fn from(redirect: Redirect<T>) -> Response {
+        redirect.into()
     }
 }
 
-#[allow(clippy::from_over_into)]
-impl<T: AsRef<str>> Into<Response> for &Redirect<T> {
-    fn into(self) -> Response {
-        let mut res = Response::new(self.status);
-        res.insert_header(LOCATION, self.location.as_ref());
+impl<T: AsRef<str>> From<&Redirect<T>> for Response {
+    fn from(redirect: &Redirect<T>) -> Response {
+        let mut res = Response::new(redirect.status);
+        res.insert_header(LOCATION, redirect.location.as_ref());
         res
     }
 }

src/request.rs

@@ -557,25 +557,22 @@ impl<State> Read for Request<State> {
     }
 }
 
-#[allow(clippy::from_over_into)]
-impl<State> Into<http::Request> for Request<State> {
-    fn into(self) -> http::Request {
-        self.req
+impl<State> From<Request<State>> for http::Request {
+    fn from(request: Request<State>) -> http::Request {
+        request.req
     }
 }
 
-#[allow(clippy::from_over_into)]
-impl<State: Default> Into<Request<State>> for http_types::Request {
-    fn into(self) -> Request<State> {
-        Request::new(State::default(), self, Vec::<Params>::new())
+impl<State: Default> From<http_types::Request> for Request<State> {
+    fn from(request: http_types::Request) -> Request<State> {
+        Request::new(State::default(), request, Vec::<Params>::new())
     }
 }
 
-#[allow(clippy::from_over_into)]
-impl<State: Clone + Send + Sync + 'static> Into<Response> for Request<State> {
-    fn into(mut self) -> Response {
+impl<State: Clone + Send + Sync + 'static> From<Request<State>> for Response {
+    fn from(mut request: Request<State>) -> Response {
         let mut res = Response::new(StatusCode::Ok);
-        res.set_body(self.take_body());
+        res.set_body(request.take_body());
         res
     }
 }

src/response.rs

@@ -301,7 +301,7 @@ impl Response {
     /// Sets the response's error, overwriting any existing error.
     ///
     /// This is particularly useful for middleware which would like to notify further
-    /// middleware that an error has occured without overwriting the existing response.
+    /// middleware that an error has occurred without overwriting the existing response.
     pub fn set_error(&mut self, error: impl Into<Error>) {
         self.error = Some(error.into());
     }
@@ -356,10 +356,9 @@ impl AsMut<http::Headers> for Response {
     }
 }
 
-#[allow(clippy::from_over_into)]
-impl Into<http::Response> for Response {
-    fn into(self) -> http_types::Response {
-        self.res
+impl From<Response> for http::Response {
+    fn from(response: Response) -> http_types::Response {
+        response.res
     }
 }
 

src/response_builder.rs

@@ -77,9 +77,8 @@ impl ResponseBuilder {
     }
 }
 
-#[allow(clippy::from_over_into)]
-impl Into<Response> for ResponseBuilder {
-    fn into(self) -> Response {
-        self.build()
+impl From<ResponseBuilder> for Response {
+    fn from(response_builder: ResponseBuilder) -> Response {
+        response_builder.build()
     }
 }