Skip to content

Commit 7857e89

Browse files
committed
Improve code coverage
1 parent 87677f3 commit 7857e89

File tree

6 files changed

+9
-6
lines changed

6 files changed

+9
-6
lines changed

pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -550,6 +550,7 @@
550550
<exclude>org.kohsuke.github.PagedIterable#toArray(org.kohsuke.github.PagedIterator)</exclude>
551551
<exclude>org.kohsuke.github.PagedIterable#PagedIterable()</exclude>
552552
<exclude>org.kohsuke.github.PagedIterator#base</exclude>
553+
<exclude>org.kohsuke.github.PagedIterable#iterator()</exclude>
553554
<exclude>org.kohsuke.github.PagedIterator#wrapUp(java.lang.Object[])</exclude>
554555
<exclude>org.kohsuke.github.PagedSearchIterable#_iterator(int)</exclude>
555556
<exclude>org.kohsuke.github.PagedSearchIterable#adapt(java.util.Iterator)</exclude>

src/main/java/org/kohsuke/github/PagedIterable.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package org.kohsuke.github;
22

33
import java.io.IOException;
4+
import java.util.Iterator;
45
import java.util.List;
56
import java.util.Set;
67

@@ -26,8 +27,8 @@ public class PagedIterable<T> implements Iterable<T> {
2627
}
2728

2829
@Nonnull
29-
public final PagedIterator<T> iterator() {
30-
return new PagedIterator<>(paginatedEndpoint.items());
30+
public final Iterator<T> iterator() {
31+
return paginatedEndpoint.iterator();
3132
}
3233

3334
@Nonnull

src/main/java/org/kohsuke/github/PagedIterator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public T next() {
4343
* Get the next page of items.
4444
*
4545
* @return a list of the next page of items.
46-
* @deprecated use PagedIterable.pageIterator().
46+
* @deprecated use PagedIterable.pages().
4747
*/
4848
@Deprecated
4949
public List<T> nextPage() {

src/test/java/org/kohsuke/github/AppTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ public void testCommit() throws Exception {
362362
.getRepository("jenkins")
363363
.getCommit("08c1c9970af4d609ae754fbe803e06186e3206f7");
364364
assertThat(commit.getParents().size(), equalTo(1));
365-
assertThat(commit.listFiles().toList().size(), equalTo(1));
365+
assertThat(commit.listFiles().withPageSize(50).toList().size(), equalTo(1));
366366
assertThat(commit.getHtmlUrl().toString(),
367367
equalTo("https://github.com/jenkinsci/jenkins/commit/08c1c9970af4d609ae754fbe803e06186e3206f7"));
368368
assertThat(commit.getLinesAdded(), equalTo(40));

src/test/java/org/kohsuke/github/GitHubTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,10 +294,11 @@ public void searchContent() throws Exception {
294294

295295
PagedSearchIterable<GHContent> r4 = searchBuilder.list();
296296

297-
GHContent c4 = r4.iterator().next();
297+
GHContent c4 = r4.withPageSize(25).iterator().next();
298298
assertThat(c4.getPath(), not(equalTo(c2.getPath())));
299299
assertThat(c4.getPath(), not(equalTo(c3.getPath())));
300300
assertThat(r4.getTotalCount(), equalTo(r2.getTotalCount()));
301+
assertThat(r4.isIncomplete(), equalTo(false));
301302

302303
// Verify qualifier not allowed to be empty
303304
IllegalArgumentException e = Assert.assertThrows(IllegalArgumentException.class,

src/test/resources/org/kohsuke/github/GitHubTest/wiremock/searchContent/mappings/6-search_code.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"id": "a9b8870b-33d7-4164-a407-310342d68536",
33
"name": "search_code",
44
"request": {
5-
"url": "/search/code?sort=indexed&order=desc&q=addClass+in%3Afile+language%3Ajs+repo%3Ajquery%2Fjquery",
5+
"url": "/search/code?sort=indexed&order=desc&q=addClass+in%3Afile+language%3Ajs+repo%3Ajquery%2Fjquery&per_page=25",
66
"method": "GET",
77
"headers": {
88
"Accept": {

0 commit comments

Comments
 (0)