Skip to content

fix: raise error when folder-based datasets are loaded without data_dir or data_files #7618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: raise error when folder-based datasets are loaded without data_dir or data_files #7618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/datasets/load.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,6 +523,16 @@ def __init__(
increase_load_count(name)

def get_module(self) -> DatasetModule:
from datasets.packaged_modules.folder_based_builder.folder_based_builder import FolderBasedBuilderConfig

# ✅ Early validation for folder-based datasets like "audiofolder"
if self.builder_cls.BUILDER_CONFIG_CLASS == FolderBasedBuilderConfig:
if not self.data_dir and not self.data_files:
raise ValueError(
"Folder-based datasets require either `data_dir` or `data_files` to be specified. "
"Neither was provided."
)

base_path = Path(self.data_dir or "").expanduser().resolve().as_posix()
patterns = (
sanitize_patterns(self.data_files)
Expand Down