required changes

Author: ved1beta

method_comparison/peft_bench/data.py

@@ -42,17 +42,14 @@ def load_test_prompts(config: dict) -> dict[str, list[str]]:
     # Use the specified prompts file or fall back to default
     prompts_file = config.get("prompts_file", DEFAULT_PROMPTS_PATH)
 
-    try:
-        with open(prompts_file) as f:
-            prompts = json.load(f)
+    with open(prompts_file) as f:
+        prompts = json.load(f)
 
-        # Apply textwrap.dedent to remove leading spaces from multiline prompts
-        for category, prompt_list in prompts.items():
-            prompts[category] = [textwrap.dedent(prompt) for prompt in prompt_list]
+    # Apply textwrap.dedent to remove leading spaces from multiline prompts
+    for category, prompt_list in prompts.items():
+        prompts[category] = [textwrap.dedent(prompt) for prompt in prompt_list]
 
-        return prompts
-    except Exception as e:
-        raise ValueError(f"Error loading prompts from {prompts_file}: {e}")
+    return prompts
 
 
 def truncate_prompt_for_model(

method_comparison/peft_bench/run.py

@@ -315,26 +315,21 @@ def main():
     # Configure print function based on verbosity
     print_fn = print if args.verbose else lambda *args, **kwargs: None
 
-    try:
-        # Validate experiment path and load configs
-        experiment_name, benchmark_config, peft_config = validate_experiment_path(args.experiment_path)
-
-        print_fn(f"Running benchmark for experiment: {experiment_name}")
+    # Validate experiment path and load configs
+    experiment_name, benchmark_config, peft_config = validate_experiment_path(args.experiment_path)
 
-        # Run the benchmark
-        result = run_benchmark(
-            benchmark_config=benchmark_config,
-            experiment_name=experiment_name,
-            experiment_path=args.experiment_path,
-            print_fn=print_fn,
-        )
+    print_fn(f"Running benchmark for experiment: {experiment_name}")
 
-        # Log and save results
-        log_results(experiment_name, result, print_fn=print)
+    # Run the benchmark
+    result = run_benchmark(
+        benchmark_config=benchmark_config,
+        experiment_name=experiment_name,
+        experiment_path=args.experiment_path,
+        print_fn=print_fn,
+    )
 
-    except Exception as e:
-        print(f"Error: {e}", file=sys.stderr)
-        return 1
+    # Log and save results
+    log_results(experiment_name, result, print_fn=print)
 
     return 0
 

method_comparison/peft_bench/utils.py

@@ -19,19 +19,19 @@
 import datetime
 import json
 import os
-import time
 import uuid
 from dataclasses import asdict, dataclass, field
 from enum import Enum
 from typing import Any, Callable, Optional
 
-import psutil  # You might need to install this: pip install psutil
+import psutil
 import torch
 from peft import PeftConfig
 
 
 # Constants
 FILE_NAME_BENCHMARK_PARAMS = "benchmark_params.json"
+FILE_NAME_DEFAULT_CONFIG = "default_config.json"
 
 # Main paths for storing results
 RESULT_PATH = os.path.join(os.path.dirname(__file__), "results")
@@ -73,7 +73,7 @@ def __post_init__(self):
         """Initialize structured data format."""
         # Default run_info
         self.run_info = {
-            "timestamp": datetime.datetime.now().isoformat(),
+            "timestamp": datetime.datetime.now(tz=datetime.timezone.utc).isoformat(),
             "duration": 0.0,
             "status": self.status.value,
             "hardware": {
@@ -347,7 +347,7 @@ def get_variant_configs(self) -> list["BenchmarkConfig"]:
 
 def generate_experiment_id() -> str:
     """Generate a unique experiment ID."""
-    return datetime.datetime.now().strftime("%Y%m%d_%H%M%S") + "_" + uuid.uuid4().hex[:8]
+    return datetime.datetime.now(tz=datetime.timezone.utc).strftime("%Y%m%d_%H%M%S")
 
 
 def validate_experiment_path(path: str) -> tuple[str, "BenchmarkConfig", Any]:
@@ -360,11 +360,16 @@ def validate_experiment_path(path: str) -> tuple[str, "BenchmarkConfig", Any]:
 
     # Check for benchmark params file
     benchmark_params_path = os.path.join(path, FILE_NAME_BENCHMARK_PARAMS)
-    if not os.path.exists(benchmark_params_path):
-        raise FileNotFoundError(f"Benchmark params not found: {benchmark_params_path}")
-
-    # Load benchmark config
-    benchmark_config = BenchmarkConfig.from_json(benchmark_params_path)
+    default_config_path = os.path.join(os.path.dirname(__file__), FILE_NAME_DEFAULT_CONFIG)
+    
+    # Use benchmark_params.json if exists, otherwise use default config
+    if os.path.exists(benchmark_params_path):
+        benchmark_config = BenchmarkConfig.from_json(benchmark_params_path)
+    elif os.path.exists(default_config_path):
+        print(f"No benchmark_params.json found in {path}, using default configuration")
+        benchmark_config = BenchmarkConfig.from_json(default_config_path)
+    else:
+        raise FileNotFoundError(f"Neither benchmark_params.json nor default_config.json found")
 
     # Try to load PEFT config
     try: