Merge pull request #1094 from Mi-Peng/lars

rwightman · web-flow · commit 7f7325271684 · 2022-01-19T08:39:49.000-08:00
fix lars
diff --git a/timm/optim/lars.py b/timm/optim/lars.py
@@ -114,7 +114,7 @@ def step(self, closure=None):
                     )
                     if group['trust_clip']:
                         trust_ratio = torch.minimum(trust_ratio / group['lr'], one_tensor)
-                    grad.add(p, alpha=weight_decay)
+                    grad.add_(p, alpha=weight_decay)
                     grad.mul_(trust_ratio)
 
                 # apply SGD update https://github.com/pytorch/pytorch/blob/1.7/torch/optim/sgd.py#L100

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ def step(self, closure=None):`
`114`	`114`	`)`
`115`	`115`	`if group['trust_clip']:`
`116`	`116`	`trust_ratio = torch.minimum(trust_ratio / group['lr'], one_tensor)`
`117`		`- grad.add(p, alpha=weight_decay)`
	`117`	`+ grad.add_(p, alpha=weight_decay)`
`118`	`118`	`grad.mul_(trust_ratio)`
`119`	`119`
`120`	`120`	`# apply SGD update https://github.com/pytorch/pytorch/blob/1.7/torch/optim/sgd.py#L100`