Skip to content

Conversation

@sharma-sanjeev156
Copy link

No description provided.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@hyochan hyochan requested a review from Copilot June 13, 2025 16:05
@hyochan hyochan added the ℹ needs more info Needs more detailed information to move forward label Jun 13, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the audio recorder/player features by adding support for new parameters, background service control, and file management improvements. Key changes include extending recorder methods with an appointmentID parameter, introducing a foreground service for Android, and refactoring event handling and error messaging.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ios/RNAudioRecorderPlayer.swift Added appointmentID parameter and new file URL logic; improved audio session configuration and encoding handling.
ios/RNAudioRecorderPlayer.m Updated method signatures to reflect new parameters.
index.ts Modified API usage to incorporate new service methods and adjusted event finish detection.
android/src/main/java/com/dooboolab.audiorecorderplayer/RNAudioRecorderPlayerModule.kt Added appointmentId support, foreground service control, and updated recorder lifecycle management; removed playback speed support.
android/src/main/java/com/dooboolab.audiorecorderplayer/ForegroundService.kt Introduced a new foreground service to support recording in the background.
android/src/main/AndroidManifest.xml Updated permission declarations to support the foreground service.
.github/workflows/codeql.yml Added CodeQL analysis workflow configuration.
Comments suppressed due to low confidence (2)

android/src/main/java/com/dooboolab/audiorecorderplayer/RNAudioRecorderPlayerModule.kt:95

  • The expression 'mediaRecorder == null' appears to be a mistake where an assignment was intended to nullify the mediaRecorder. Change it to 'mediaRecorder = null' to correctly reset the variable.
mediaRecorder == null

android/src/main/java/com/dooboolab/audiorecorderplayer/RNAudioRecorderPlayerModule.kt:173

  • [nitpick] The error message key 'resumeReocrder' is misspelled. It should be corrected to 'resumeRecorder' to maintain consistency and clarity.
promise.reject("resumeReocrder", "Recorder is null.")

let settings = [
AVSampleRateKey: sampleRate!,
AVFormatIDKey: avFormat,
AVFormatIDKey: avFormat!,
Copy link

Copilot AI Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the 'encoding' value is not recognized in the conditional branches, 'avFormat' remains nil and force unwrapping it will cause a runtime crash. Consider adding a default case or error handling for unrecognized encoding values.

Copilot uses AI. Check for mistakes.
}

if (event.isFinished) {
if (event.currentPosition === event.duration) {
Copy link

Copilot AI Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using strict equality for floating point values may be unreliable due to precision issues. Consider using a tolerance-based comparison to determine if the playback has finished.

Suggested change
if (event.currentPosition === event.duration) {
const TOLERANCE = 0.001;
if (Math.abs(event.currentPosition - event.duration) < TOLERANCE) {

Copilot uses AI. Check for mistakes.
@hyochan hyochan force-pushed the main branch 3 times, most recently from 11feb3a to 14b6492 Compare September 12, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ℹ needs more info Needs more detailed information to move forward

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants