enabled more linters, need to fix the issues

Signed-off-by: Angelo De Caro <[email protected]>

Author: adecaro

.golangci.yml

@@ -12,7 +12,7 @@ linters:
     - ginkgolinter
 #    - gocognit
 #    - goconst
-#    - gocritic
+    - gocritic
 #    - godot
 #    - gosec
 #    - intrange
@@ -25,7 +25,7 @@ linters:
     - nilnesserr
     - nolintlint
 #    - paralleltest
-#    - prealloc
+    - prealloc
 #    - promlinter
 #    - revive
 #    - rowserrcheck
@@ -38,7 +38,7 @@ linters:
     - wastedassign
     - whitespace
     - govet
-#    - staticcheck
+    - staticcheck
     - canonicalheader
 #    - copyloopvar
     - dupword
@@ -50,9 +50,16 @@ linters:
     - nakedret
     - sloglint
     - usestdlibvars
+    - bodyclose
     # wrapcheck is not working as expected. It is categorizing internal packages as external.
     #- wrapcheck
   settings:
+    gocritic:
+      settings:
+        hugeParam:
+          sizeThreshold: 64   # bytes; tune for your codebase
+        rangeValCopy:
+          sizeThreshold: 64
     errcheck:
       # Report about not checking of errors in type assertions: `a := b.(MyStruct)`.
       # Such cases aren't reported by default.
@@ -222,4 +229,6 @@ linters:
 #      local-prefixes:
 #        - github.ibm.com/decentralized-trust-research/idap
 #  exclusions:
-#    generated: lax
+#    generated: lax
+issues:
+  exclude-use-default: false

cmd/tokengen/cobra/pp/common/common.go

@@ -51,17 +51,17 @@ func GetX509Identity(entry string) (driver.Identity, error) {
 }
 
 // SetupIssuersAndAuditors sets up the issuers and auditors for the given public parameters
-func SetupIssuersAndAuditors(pp PP, Auditors, Issuers []string) error {
-	// Auditors
-	for _, auditor := range Auditors {
+func SetupIssuersAndAuditors(pp PP, auditors, issuers []string) error {
+	// auditors
+	for _, auditor := range auditors {
 		id, err := GetX509Identity(auditor)
 		if err != nil {
 			return errors.WithMessagef(err, "failed to get auditor identity [%s]", auditor)
 		}
 		pp.AddAuditor(id)
 	}
-	// Issuers
-	for _, issuer := range Issuers {
+	// issuers
+	for _, issuer := range issuers {
 		id, err := GetX509Identity(issuer)
 		if err != nil {
 			return errors.WithMessagef(err, "failed to get issuer identity [%s]", issuer)

token/core/common/ppm.go

@@ -25,7 +25,7 @@ type PublicParamsManager[T driver.PublicParameters] struct {
 }
 
 func NewPublicParamsManager[T driver.PublicParameters](
-	PublicParamsDeserializer PublicParamsDeserializer[T],
+	publicParamsDeserializer PublicParamsDeserializer[T],
 	driverName driver.TokenDriverName,
 	driverVersion driver.TokenDriverVersion,
 	ppRaw []byte,
@@ -37,7 +37,7 @@ func NewPublicParamsManager[T driver.PublicParameters](
 	if len(ppRaw) == 0 {
 		return nil, errors.Errorf("empty public parameters")
 	}
-	pp, err := PublicParamsDeserializer.DeserializePublicParams(ppRaw, driverName, driverVersion)
+	pp, err := publicParamsDeserializer.DeserializePublicParams(ppRaw, driverName, driverVersion)
 	if err != nil {
 		return nil, err
 	}

token/core/common/validator.go

@@ -39,7 +39,7 @@ type Context[P driver.PublicParameters, T any, TA driver.TransferAction, IA driv
 }
 
 func (c *Context[P, T, TA, IA, DS]) CountMetadataKey(key string) {
-	c.MetadataCounter[key] = c.MetadataCounter[key] + 1
+	c.MetadataCounter[key]++
 }
 
 type ValidateTransferFunc[P driver.PublicParameters, T any, TA driver.TransferAction, IA driver.IssueAction, DS driver.Deserializer] func(c context.Context, ctx *Context[P, T, TA, IA, DS]) error
@@ -64,7 +64,7 @@ type Validator[P driver.PublicParameters, T any, TA driver.TransferAction, IA dr
 }
 
 func NewValidator[P driver.PublicParameters, T any, TA driver.TransferAction, IA driver.IssueAction, DS driver.Deserializer](
-	Logger logging.Logger,
+	logger logging.Logger,
 	publicParams P,
 	deserializer DS,
 	actionDeserializer ActionDeserializer[TA, IA],
@@ -73,7 +73,7 @@ func NewValidator[P driver.PublicParameters, T any, TA driver.TransferAction, IA
 	auditingValidators []ValidateAuditingFunc[P, T, TA, IA, DS],
 ) *Validator[P, T, TA, IA, DS] {
 	return &Validator[P, T, TA, IA, DS]{
-		Logger:             Logger,
+		Logger:             logger,
 		PublicParams:       publicParams,
 		Deserializer:       deserializer,
 		ActionDeserializer: actionDeserializer,

token/core/zkatdlog/nogh/protos-go/utils/proto.go

@@ -14,9 +14,7 @@ import (
 )
 
 func ToProtoG1Slice(input []*mathlib.G1) ([]*math.G1, error) {
-	return protos.ToProtosSliceFunc(input, func(s *mathlib.G1) (*math.G1, error) {
-		return ToProtoG1(s)
-	})
+	return protos.ToProtosSliceFunc(input, ToProtoG1)
 }
 
 func ToProtoG1(s *mathlib.G1) (*math.G1, error) {

token/request.go

@@ -1194,7 +1194,7 @@ func (r *Request) Issues() []*Issue {
 
 // Transfers returns the list of transfers.
 func (r *Request) Transfers() []*Transfer {
-	var transfers []*Transfer
+	transfers := make([]*Transfer, 0, len(r.Metadata.Transfers))
 	for _, transfer := range r.Metadata.Transfers {
 		transfers = append(transfers, &Transfer{
 			Senders:      transfer.Senders(),

token/services/config/config.go

@@ -152,7 +152,7 @@ func (m *Service) Configurations() ([]Configuration, error) {
 		return nil, err
 	}
 
-	var tms []Configuration
+	tms := make([]Configuration, 0, len(tmsConfigs))
 	for key, config := range tmsConfigs {
 		tms = append(tms, NewConfiguration(m.cp, m.version, key, config.ID()))
 	}

token/services/network/common/rws/translator/translator.go

@@ -124,7 +124,7 @@ func (t *Translator) AddPublicParamsDependency() error {
 }
 
 func (t *Translator) QueryTokens(ctx context.Context, ids []*token.ID) ([][]byte, error) {
-	var res [][]byte
+	res := make([][]byte, 0, len(ids))
 	var errs []error
 	for _, id := range ids {
 		outputID, err := t.KeyTranslator.CreateOutputKey(id.TxId, id.Index)

token/stream.go

@@ -216,7 +216,7 @@ func (is *InputStream) Count() int {
 // Owners returns a list of identities that own the tokens in the stream
 func (is *InputStream) Owners() *OwnerStream {
 	ownerMap := map[string]bool{}
-	var owners []string
+	owners := make([]string, 0, len(is.inputs))
 	for _, input := range is.inputs {
 		_, ok := ownerMap[input.Owner.UniqueID()]
 		if ok {
@@ -255,7 +255,7 @@ func (is *InputStream) At(i int) *Input {
 
 // IDs returns the IDs of the inputs.
 func (is *InputStream) IDs() []*token.ID {
-	var res []*token.ID
+	res := make([]*token.ID, 0, len(is.inputs))
 	for _, input := range is.inputs {
 		res = append(res, input.Id)
 	}