You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The protobuf update (for Java at least) is significant enough that a
minor rather than patch-level version increase is probably warranted.
Also update dev dependencies to latest versions.
Signed-off-by: Mark S. Lewis <[email protected]>
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+5-5Lines changed: 5 additions & 5 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -12,15 +12,15 @@ Here are a few guidelines to help you contribute successfully...
12
12
13
13
## Issues
14
14
15
-
Issues are tracked in the GitHub repository [Issues](https://github.com/hyperledger/fabric-gateway/issues). *Please do not use issues to ask questions.*
15
+
Issues are tracked in the GitHub repository [Issues](https://github.com/hyperledger/fabric-gateway/issues). _Please do not use issues to ask questions._
16
16
17
17
If you find a bug which we don't already know about, you can help us by creating a new issue describing the problem. Please include as much detail as possible to help us track down the cause.
18
18
19
19
## Enhancements
20
20
21
-
If you have a proposal for new functionality, either for the community to consider or that you would like to contribute yourself, please first raise an issue describing this functionality. Make the title something reasonably short but descriptive, and include a [user story](https://en.wikipedia.org/wiki/User_story) description of the enhancement, followed by any supporting information. For example, [issue #198](https://github.com/hyperledger/fabric-gateway/issues/198). The *"So that"* statement provides useful context about the motivation for the enhancement, and helps in determining whether any changes successfully satisfy the requirement.
21
+
If you have a proposal for new functionality, either for the community to consider or that you would like to contribute yourself, please first raise an issue describing this functionality. Make the title something reasonably short but descriptive, and include a [user story](https://en.wikipedia.org/wiki/User_story) description of the enhancement, followed by any supporting information. For example, [issue #198](https://github.com/hyperledger/fabric-gateway/issues/198). The _"So that"_ statement provides useful context about the motivation for the enhancement, and helps in determining whether any changes successfully satisfy the requirement.
22
22
23
-
*Make sure you have the support of the maintainers and community before investing a lot of effort in project enhancements.*
23
+
_Make sure you have the support of the maintainers and community before investing a lot of effort in project enhancements._
24
24
25
25
## Contributing code
26
26
@@ -36,7 +36,7 @@ It is helpful to create work-in-progress pull requests as [draft](https://docs.g
36
36
37
37
### Go
38
38
39
-
Go code uses [testify](https://github.com/stretchr/testify) for assertions, and [gomock](https://github.com/uber-go/mock) for mock implementations. The standard [errors](https://pkg.go.dev/errors) package is used; not any third-party error packages.
39
+
Go code uses [testify](https://github.com/stretchr/testify) for assertions, and [mockery](https://vektra.github.io/mockery/) for mock implementations. The standard [errors](https://pkg.go.dev/errors) package is used; not any third-party error packages.
40
40
41
41
Consider recommendations from these resources:
42
42
@@ -54,7 +54,7 @@ Node code is written only in [TypeScript](https://www.typescriptlang.org/), and
54
54
55
55
### Java
56
56
57
-
Java code uses [JUnit](https://junit.org/) as the test runner, [AssertJ](https://assertj.github.io/doc/) for assertions, and [Mockito](https://site.mockito.org/) for mock implementations. [PMD](https://pmd.github.io/) is used to perform static analysis of the code, and [Spotless](https://github.com/diffplug/spotless) (with [Palantir Java format](https://github.com/palantir/palantir-java-format) rules) checks consistent code formatting.
57
+
Java code uses [JUnit](https://junit.org/) as the test runner, [AssertJ](https://assertj.github.io/doc/) for assertions, and [Mockito](https://site.mockito.org/) for mock implementations. [PMD](https://pmd.github.io/) is used to perform static analysis of the code, and [Spotless](https://github.com/diffplug/spotless) (with [Palantir Java format](https://github.com/palantir/palantir-java-format) rules) checks consistent code formatting.
0 commit comments