Skip to content

Commit 2ccb2bb

Browse files
authored
Merge pull request #142 from kaleido-io/fetchreferences
[fetchreferences] fetchreferences for event table and tx details
2 parents bcb5517 + c435f76 commit 2ccb2bb

File tree

4 files changed

+23
-13
lines changed

4 files changed

+23
-13
lines changed

src/components/Cards/EventCards/EventCardWrapper.tsx

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { useTranslation } from 'react-i18next';
33
import {
44
FF_EVENTS_CATEGORY_MAP,
55
FF_TX_CATEGORY_MAP,
6+
getEnrichedEventText,
67
IEvent,
78
} from '../../../interfaces';
89
import { getFFTime } from '../../../utils';
@@ -26,14 +27,6 @@ export const EventCardWrapper = ({
2627
}: Props) => {
2728
const { t } = useTranslation();
2829

29-
const getEnrichedText = (event: IEvent) => {
30-
const eventObject = FF_EVENTS_CATEGORY_MAP[event.type];
31-
if (eventObject) {
32-
return eventObject.enrichedEventString(event);
33-
}
34-
return t('event');
35-
};
36-
3730
return (
3831
<>
3932
<BaseCard
@@ -47,7 +40,7 @@ export const EventCardWrapper = ({
4740
? t(FF_TX_CATEGORY_MAP[event.transaction?.type]?.nicename)
4841
: t(t(FF_EVENTS_CATEGORY_MAP[event.type]?.nicename))
4942
}
50-
description={getEnrichedText(event)}
43+
description={getEnrichedEventText(event)}
5144
timestamp={getFFTime(event.created)}
5245
status={<HashPopover address={event.id} shortHash paper />}
5346
color={FF_EVENTS_CATEGORY_MAP[event.type]?.color}

src/interfaces/enums/eventTypes.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,14 @@ interface IEventCategory {
4848
nicename: string;
4949
}
5050

51+
export const getEnrichedEventText = (event: IEvent) => {
52+
const eventObject = FF_EVENTS_CATEGORY_MAP[event.type];
53+
if (eventObject) {
54+
return eventObject.enrichedEventString(event);
55+
}
56+
return t('event');
57+
};
58+
5159
export const FF_EVENTS_CATEGORY_MAP: {
5260
[key in FF_EVENTS]: IEventCategory;
5361
} = {

src/pages/Activity/views/Events.tsx

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ import {
3838
EventFilters,
3939
FF_EVENTS_CATEGORY_MAP,
4040
FF_Paths,
41+
getEnrichedEventText,
4142
ICreatedFilter,
4243
IDataTableRecord,
4344
IEvent,
@@ -137,9 +138,11 @@ export const ActivityEvents: () => JSX.Element = () => {
137138
fetchCatcher(
138139
`${FF_Paths.nsPrefix}/${selectedNamespace}${
139140
FF_Paths.events
140-
}?limit=${rowsPerPage}&count&skip=${rowsPerPage * currentPage}${
141-
createdFilterObject.filterString
142-
}${filterString !== undefined ? filterString : ''}`
141+
}?limit=${rowsPerPage}&fetchreferences&count&skip=${
142+
rowsPerPage * currentPage
143+
}${createdFilterObject.filterString}${
144+
filterString !== undefined ? filterString : ''
145+
}`
143146
)
144147
.then((eventRes: IPagedEventResponse) => {
145148
if (isMounted) {
@@ -186,6 +189,7 @@ export const ActivityEvents: () => JSX.Element = () => {
186189

187190
const eventsColumnHeaders = [
188191
t('type'),
192+
t('details'),
189193
t('id'),
190194
t('reference'),
191195
t('transactionID'),
@@ -204,6 +208,11 @@ export const ActivityEvents: () => JSX.Element = () => {
204208
/>
205209
),
206210
},
211+
{
212+
value: (
213+
<FFTableText color="secondary" text={getEnrichedEventText(event)} />
214+
),
215+
},
207216
{
208217
value: (
209218
<HashPopover shortHash={true} address={event.id}></HashPopover>

src/pages/Activity/views/TransactionDetails.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ export const TransactionDetails: () => JSX.Element = () => {
128128
});
129129
// Transaction events
130130
fetchCatcher(
131-
`${FF_Paths.nsPrefix}/${selectedNamespace}${FF_Paths.events}?tx=${txID}`
131+
`${FF_Paths.nsPrefix}/${selectedNamespace}${FF_Paths.events}?tx=${txID}&fetchreferences`
132132
)
133133
.then((events: IEvent[]) => {
134134
isMounted && setTxEvents(events);

0 commit comments

Comments
 (0)