Skip to content

Commit cd45345

Browse files
authored
Merge pull request #208 from kaleido-io/fetch-detailed-operation-status
Add 'Detail' to operation slide out
2 parents 9e2b4a5 + f434abc commit cd45345

File tree

6 files changed

+17
-8
lines changed

6 files changed

+17
-8
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ We welcome contributions to the FireFly Project in many forms, and
44
there's always plenty to do!
55

66
Please visit the
7-
[contributors guide](https://hyperledger.github.io/firefly/contributors/contributors.html) in the
7+
[contributors guide](https://hyperledger.github.io/firefly/contributors/index.html) in the
88
docs to learn how to make contributions to this exciting project.
99

1010
<a rel="license" href="http://creativecommons.org/licenses/by/4.0/"><img alt="Creative Commons License" style="border-width:0" src="https://i.creativecommons.org/l/by/4.0/88x31.png" /></a><br />This work is licensed under a <a rel="license" href="http://creativecommons.org/licenses/by/4.0/">Creative Commons Attribution 4.0 International License</a>.

src/components/Slides/OperationSlide.tsx

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,20 +57,25 @@ export const OperationSlide: React.FC<Props> = ({ op, open, onClose }) => {
5757
<FFJsonViewer json={op.error} />
5858
</Grid>
5959
)}
60-
{/* Input and Output */}
61-
{(op.input || op.output) && (
62-
<SlideSectionHeader title={t('inputAndOutput')} />
60+
{/* Input, Output and Detail */}
61+
{(op.input || op.output || op.detail) && (
62+
<SlideSectionHeader title={t('inputOutputDetail')} />
6363
)}
6464
{op.input && (
6565
<Grid container item pb={DEFAULT_PADDING}>
6666
<JsonViewAccordion isOpen header={t('input')} json={op.input} />
6767
</Grid>
6868
)}
6969
{op.output && (
70-
<Grid container item>
70+
<Grid container item pb={DEFAULT_PADDING}>
7171
<JsonViewAccordion isOpen header={t('output')} json={op.output} />
7272
</Grid>
7373
)}
74+
{op.detail && (
75+
<Grid container item>
76+
<JsonViewAccordion isOpen header={t('detail')} json={op.detail} />
77+
</Grid>
78+
)}
7479
</Grid>
7580
</DisplaySlide>
7681
</>

src/interfaces/api.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -282,6 +282,7 @@ export interface IOperation {
282282
id: string;
283283
success: boolean;
284284
};
285+
detail?: any;
285286
created: string;
286287
updated: string;
287288
retry?: string;

src/interfaces/constants.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,8 @@ export const FF_Paths = {
8585
messageTxById: (msgId: string) => `/messages/${msgId}/transaction`,
8686
// Operations
8787
operations: '/operations',
88-
operationsById: (opId: string) => `/operations/${opId}`,
88+
operationsById: (opId: string, fetchStatus: boolean) =>
89+
`/operations/${opId}${fetchStatus ? '?fetchstatus=true' : ''}`,
8990
// Subscriptions
9091
subscriptions: '/subscriptions',
9192
subscriptionsById: (subId: string) => `/subscriptions/${subId}?fetchstatus`,

src/pages/Activity/views/Operations.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,8 @@ export const ActivityOperations: () => JSX.Element = () => {
9292
slideID &&
9393
fetchCatcher(
9494
`${FF_Paths.nsPrefix}/${selectedNamespace}${FF_Paths.operationsById(
95-
slideID
95+
slideID,
96+
true
9697
)}`
9798
)
9899
.then((opRes: IOperation) => {

src/translations/en.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@
9292
"definition": "Definition",
9393
"description": "Description",
9494
"details": "Details",
95+
"detail": "Detail",
9596
"did": "DID",
9697
"docs": "Docs",
9798
"download": "Download",
@@ -138,7 +139,7 @@
138139
"in": "In",
139140
"info": "Info",
140141
"input": "Input",
141-
"inputAndOutput": "Input and Output",
142+
"inputOutputDetail": "Input, Output and Detail",
142143
"interfaceID": "Interface ID",
143144
"interfaces": "Interfaces",
144145
"joined": "Joined",

0 commit comments

Comments
 (0)