Remove seccomp

Signed-off-by: Doru Blânzeanu <[email protected]>

Author: dblnz

Cargo.lock

@@ -87,15 +87,10 @@ clippy target=default-target: (check target)
 # There may be tests that we really want to ignore so we cant just use --ignored and run then we have to
 # specify the test name of the ignored tests that we want to run
 # Additionally, we have to run the tests with the function_call_metrics feature enabled separately
-test target=default-target features="": (test-seccomp target features)
+test target=default-target features="":
     cargo test {{ if features =="" {''} else if features=="no-default-features" {"--no-default-features" } else {"--no-default-features -F " + features } }}  --profile={{ if target == "debug" {"dev"} else { target } }}
     cargo test test_metrics {{ if features =="" {''} else if features=="no-default-features" {"--no-default-features" } else {"--no-default-features -F " + features } }}  --profile={{ if target == "debug" {"dev"} else { target } }} -- --ignored 
 
-test-seccomp target=default-target features="": 
-    cargo test {{ if features =="" {'--no-default-features -F "kvm,mshv3,seccomp"'} else {"--no-default-features -F seccomp," + features } }} --profile={{ if target == "debug" {"dev"} else { target } }} -- --test-threads=1
-    cargo test {{ if features =="" {'--no-default-features -F "kvm,mshv3,seccomp"'} else {"--no-default-features -F seccomp," + features } }} test_metrics --profile={{ if target == "debug" {"dev"} else { target } }} -- --ignored --test-threads=1 
-    cargo test {{ if features =="" {'--no-default-features -F "kvm,mshv3,seccomp"'} else {"--no-default-features -F seccomp," + features } }} test_gather_metrics --profile={{ if target == "debug" {"dev"} else { target } }} -- --ignored --test-threads=1 
-
 examples-ci target=default-target features="": (build-rust-wasm-examples target)
     cargo run {{ if features =="" {''} else {"--no-default-features -F " + features } }} --profile={{ if target == "debug" {"dev"} else { target } }} --example helloworld
     cargo run {{ if features =="" {''} else {"--no-default-features -F " + features } }} --profile={{ if target == "debug" {"dev"} else { target } }} --example hostfuncs

Justfile

@@ -85,7 +85,6 @@ tar = "0.4.44"
 [features]
 default = ["function_call_metrics", "kvm", "mshv3"]
 function_call_metrics = ["hyperlight-host/function_call_metrics"]
-seccomp = ["hyperlight-host/seccomp"]
 print_debug = ["hyperlight-host/print_debug"]
 crashdump = ["hyperlight-host/crashdump"]
 gdb = ["hyperlight-host/gdb"]

src/hyperlight_wasm/Cargo.toml

@@ -15,8 +15,6 @@ limitations under the License.
 */
 
 use hyperlight_host::func::{HostFunction, ParameterTuple, Registerable, SupportedReturnType};
-#[cfg(all(feature = "seccomp", target_os = "linux"))]
-use hyperlight_host::sandbox::ExtraAllowedSyscall;
 use hyperlight_host::sandbox::config::SandboxConfiguration;
 use hyperlight_host::{GuestBinary, Result, UninitializedSandbox, new_error};
 
@@ -46,18 +44,6 @@ impl Registerable for ProtoWasmSandbox {
             .ok_or(new_error!("inner sandbox was none"))
             .and_then(|sb| sb.register(name, hf))
     }
-    #[cfg(all(feature = "seccomp", target_os = "linux"))]
-    fn register_host_function_with_syscalls<Args: ParameterTuple, Output: SupportedReturnType>(
-        &mut self,
-        name: &str,
-        hf: impl Into<HostFunction<Output, Args>>,
-        eas: Vec<ExtraAllowedSyscall>,
-    ) -> Result<()> {
-        self.inner
-            .as_mut()
-            .ok_or(new_error!("inner sandbox was none"))
-            .and_then(|sb| sb.register_host_function_with_syscalls(name, hf, eas))
-    }
 }
 
 impl ProtoWasmSandbox {
@@ -119,25 +105,6 @@ impl ProtoWasmSandbox {
             .register(name, host_func)
     }
 
-    /// Register the given host function `host_func` with `self` along with a vec of syscalls the
-    /// function requires and return `Ok` if the registration succeeded, and a descriptive `Err` if
-    /// it didn't.
-    #[cfg(all(feature = "seccomp", target_os = "linux"))]
-    pub fn register_with_extra_allowed_syscalls<
-        Args: ParameterTuple,
-        Output: SupportedReturnType,
-    >(
-        &mut self,
-        name: impl AsRef<str>,
-        host_func: impl Into<HostFunction<Output, Args>>,
-        extra_allowed_syscalls: impl IntoIterator<Item = ExtraAllowedSyscall>,
-    ) -> Result<()> {
-        self.inner
-            .as_mut()
-            .ok_or(new_error!("inner sandbox was none"))?
-            .register_with_extra_allowed_syscalls(name, host_func, extra_allowed_syscalls)
-    }
-
     /// Register the given host printing function `print_func` with `self`.
     /// Return `Ok` if the registration succeeded, and a descriptive `Err` otherwise.
     pub fn register_print(
@@ -149,21 +116,6 @@ impl ProtoWasmSandbox {
             .ok_or(new_error!("inner sandbox was none"))?
             .register_print(print_func)
     }
-
-    /// Register the given host printing function `print_func` with `self` along with a
-    /// vec of syscalls the function requires.
-    /// Return `Ok` if the registration succeeded, and a descriptive `Err` otherwise.
-    #[cfg(all(feature = "seccomp", target_os = "linux"))]
-    pub fn register_print_with_extra_allowed_syscalls(
-        &mut self,
-        print_func: impl Into<HostFunction<i32, (String,)>>,
-        extra_allowed_syscalls: impl IntoIterator<Item = ExtraAllowedSyscall>,
-    ) -> Result<()> {
-        self.inner
-            .as_mut()
-            .ok_or(new_error!("inner sandbox was none"))?
-            .register_print_with_extra_allowed_syscalls(print_func, extra_allowed_syscalls)
-    }
 }
 
 impl std::fmt::Debug for ProtoWasmSandbox {