Apply suggestions from code review

Co-authored-by: Robert Knight <[email protected]>

Author: esanzgar

src/annotator/test/sidebar-test.js

@@ -358,7 +358,7 @@ describe('Sidebar', () => {
       });
     });
 
-    describe('on "loginRequest" event', () => {
+    describe('on "loginRequested" event', () => {
       it('calls the onLoginRequest callback function if one was provided', () => {
         const onLoginRequest = sandbox.stub();
         createSidebar({ services: [{ onLoginRequest }] });
@@ -445,7 +445,7 @@ describe('Sidebar', () => {
         assert.called(onSignupRequest);
       }));
 
-    describe('on "profileRequest" event', () =>
+    describe('on "profileRequested" event', () =>
       it('calls the onProfileRequest callback function', () => {
         const onProfileRequest = sandbox.stub();
         createSidebar({ services: [{ onProfileRequest }] });

src/sidebar/components/test/HypothesisApp-test.js

@@ -223,7 +223,7 @@ describe('HypothesisApp', () => {
         fakeServiceConfig.returns({});
       });
 
-      it('sends "signupRequest" event', () => {
+      it('sends "signupRequested" event', () => {
         const wrapper = createComponent();
         clickSignUp(wrapper);
         assert.calledWith(fakeFrameSync.notifyHost, 'signupRequested');

src/types/bridge-events.d.ts

@@ -8,12 +8,12 @@
  */
 export type HostToSidebarEvent =
   /**
-   * The host is asking the sidebar to delete a frame.
+   * A guest frame has been destroyed
    */
   | 'destroyFrame'
 
   /**
-   * The host is asking the sidebar to set the annotation highlights on/off.
+   * Highlights have been toggled on/off.
    */
   | 'setVisibleHighlights'
 
@@ -42,7 +42,7 @@ export type GuestToSidebarEvent =
   | 'focusAnnotations'
 
   /**
-   * The guest is asking the sidebar to relay the message to open the sidebar.
+   * Request that the sidebar be opened
    */
   | 'openSidebar'
 
@@ -52,7 +52,7 @@ export type GuestToSidebarEvent =
   | 'showAnnotations'
 
   /**
-   * The guest notifies the sidebar to synchronize about the anchoring status of annotations.
+   * Report whether annotations were successfully anchored in the guest
    */
   | 'sync'
 
@@ -76,7 +76,7 @@ export type SidebarToGuestEvent =
   | 'focusAnnotations'
 
   /**
-   * The sidebar is asking the guest(s) to get the document metadata.
+   * Request the URL and other metadata about the document in this guest.
    */
   | 'getDocumentInfo'