removing notification system (#147)

Author: MmagdyHafezZ

apps/api-gateway/src/api/api.controller.ts

@@ -134,27 +134,6 @@ export class ApiController {
     );
   }
 
-  // Special handling for notification SSE endpoints
-  @Get("notifications/stream")
-  @UseGuards(DynamicJwtCookieAuthGuard)
-  @ApiOperation({ summary: "Stream notifications" })
-  async handleNotificationStream(
-    @Req() request: UserSessionRequest,
-    @Res() response: Response,
-  ) {
-    const { endpoint, extraHeaders } = this.apiService.getForwardingDetails(
-      DownstreamService.MARK_API,
-      request,
-    );
-
-    // Forward as SSE
-    await this.apiService.forwardSSERequest(
-      request,
-      response,
-      endpoint,
-      extraHeaders,
-    );
-  }
   @All("/*")
   @UseGuards(DynamicJwtCookieAuthGuard)
   @ApiOperation({ summary: "Handle API requests for the Mark API" })

apps/api/src/api/api.module.ts

@@ -12,7 +12,6 @@ import { JobModule } from "./Job/job.module";
 import { LlmModule } from "./llm/llm.module";
 import { ReportsModule } from "./report/report.module";
 import { ChatModule } from "./user/modules/chat.module";
-import { NotificationsModule } from "./user/modules/notification.module";
 
 @Module({
   controllers: [ApiController],
@@ -28,7 +27,6 @@ import { NotificationsModule } from "./user/modules/notification.module";
     JobModule,
     ReportsModule,
     ChatModule,
-    NotificationsModule,
     FilesModule,
   ],
 })

apps/api/src/api/report/report.module.ts

@@ -5,7 +5,6 @@ import { AdminAuthModule } from "src/auth/admin-auth.module";
 import { PrismaService } from "src/prisma.service";
 import { FilesService } from "../files/services/files.service";
 import { S3Service } from "../files/services/s3.service";
-import { NotificationsService } from "../user/services/notification.service";
 import { ReportsController } from "./controllers/report.controller";
 import { FloService } from "./services/flo.service";
 import { ReportsService } from "./services/report.service";
@@ -14,7 +13,6 @@ import { ReportsService } from "./services/report.service";
   providers: [
     ReportsService,
     FloService,
-    NotificationsService,
     PrismaService,
     FilesService,
     S3Service,

apps/api/src/api/report/services/report.service.ts

@@ -13,7 +13,6 @@ import axios from "axios";
 import * as jwt from "jsonwebtoken";
 import * as natural from "natural";
 import { FilesService } from "src/api/files/services/files.service";
-import { NotificationsService } from "src/api/user/services/notification.service";
 import {
   UserRole,
   UserSession,
@@ -53,21 +52,17 @@ export class ReportsService {
     private readonly floService: FloService,
     private readonly prisma: PrismaService,
     private readonly filesService: FilesService,
-    private readonly notificationsService: NotificationsService,
     private readonly adminEmailService: AdminEmailService,
   ) {}
   private getPrivateKey(): string {
     const raw = process.env.GITHUB_APP_PRIVATE_KEY || "";
 
-    // Handle different possible formats
     let processed = raw.trim();
 
-    // If the key contains literal \n strings, convert them to actual newlines
     if (processed.includes("\\n")) {
       processed = processed.replaceAll("\\n", "\n");
     }
 
-    // Ensure proper PEM format
     if (!processed.startsWith("-----BEGIN")) {
       throw new InternalServerErrorException(
         "Invalid private key format: missing BEGIN marker",
@@ -2316,23 +2311,6 @@ A new related issue has been created: #${issue.number}
               ? " (Not Reproducible/Invalid)"
               : ""
       : "";
-
-    await this.notificationsService.createNotification(
-      report.reporterId,
-      "ISSUE_STATUS_CHANGE",
-      `Issue #${
-        report.issueNumber || reportId
-      } Status: ${statusText}${reasonText}`,
-      statusMessage || this.getDefaultStatusMessage(newStatus),
-      {
-        reportId,
-        oldStatus: report.status,
-        newStatus,
-        issueNumber: report.issueNumber,
-        statusMessage,
-        closureReason,
-      },
-    );
   }
   /**
    * Track issue status changes and notify users

apps/api/src/api/user/controllers/notification.controller.ts

@@ -45,7 +45,6 @@ export class AppModule implements NestModule {
         { path: "/v1/user-session", method: RequestMethod.GET },
         { path: "/v1/reports*", method: RequestMethod.ALL },
         { path: "/v1/chats*", method: RequestMethod.ALL },
-        { path: "/v1/notifications*", method: RequestMethod.ALL },
         { path: "/v1/files*", method: RequestMethod.ALL },
         { path: "/v1/admin*", method: RequestMethod.ALL },
         { path: "/v2/assignments/*", method: RequestMethod.ALL },