Skip to content

fixes #45 encode/decode the filepath correctly #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixes #45 encode/decode the filepath correctly #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bin/src/model/dto/config/cached_package.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import 'package:meta/meta.dart';
@immutable
class CachedPackage {
final String name;
final String rootUri;
final Uri rootUri;
final String packageUri;

const CachedPackage({
Expand All @@ -24,7 +24,7 @@ class CachedPackage {
}
return CachedPackage(
name: json['name'] as String,
rootUri: rootUri,
rootUri: Uri.parse(rootUri),
packageUri: json['packageUri'] as String,
);
}
Expand Down
3 changes: 2 additions & 1 deletion bin/src/repo/license_repository.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ class LicenseRepository {
);
}

static String? _guessLocalLicenseFile(String packagePath) {
static String? _guessLocalLicenseFile(Uri packagePathUri) {
final packagePath = packagePathUri.toFilePath();
if (packagePath.isNotEmpty) {
final packageFolder = Directory(packagePath);
if (!packageFolder.existsSync()) {
Expand Down