Fix a11y Labeling on PendingUpdatesSummary

The school label for this select is buried within the SVG, safari
doesn't love that. Might be a bug in Safari, or possibly the check, but
the fix is easy and harmless so going this way.

Author: jrjohnson

packages/frontend/app/components/pending-updates-summary.gjs

@@ -4,7 +4,7 @@ import { cached, tracked } from '@glimmer/tracking';
 import { filter } from 'rsvp';
 import { TrackedAsyncData } from 'ember-async-data';
 import { findById } from 'ilios-common/utils/array-helpers';
-import { uniqueId, get, hash } from '@ember/helper';
+import { get, hash } from '@ember/helper';
 import FaIcon from 'ilios-common/components/fa-icon';
 import t from 'ember-intl/helpers/t';
 import gt from 'ember-truth-helpers/helpers/gt';
@@ -88,60 +88,58 @@ export default class PendingUpdatesSummaryComponent extends Component {
     });
   }
   <template>
-    {{#let (uniqueId) as |template-id|}}
-      <div
-        class="pending-updates-summary small-component {{if this.haveUpdates 'alert'}}"
-        data-test-pending-updates-summary
-        ...attributes
-      >
-        <h3 data-test-title>
-          {{#if this.haveUpdates}}
-            <FaIcon @icon="triangle-exclamation" class="no" />
+    <div
+      class="pending-updates-summary small-component {{if this.haveUpdates 'alert'}}"
+      data-test-pending-updates-summary
+      ...attributes
+    >
+      <h3 data-test-title>
+        {{#if this.haveUpdates}}
+          <FaIcon @icon="triangle-exclamation" class="no" />
+        {{/if}}
+        {{t "general.pendingUpdatesSummaryTitle"}}
+      </h3>
+      <div id="schoolsfilter" class="filter" data-test-schools>
+        <label class="inline-label">
+          <FaIcon @icon="building-columns" @title={{t "general.school"}} />
+        </label>
+        <div id="school-selection" class="inline-data">
+          {{#if (gt @schools.length 1)}}
+            <select
+              aria-label={{t "general.school"}}
+              {{on "change" (pick "target.value" (set this "selectedSchoolId"))}}
+            >
+              {{#each (sortBy "title" @schools) as |school|}}
+                <option value={{school.id}} selected={{eq school.id this.bestSelectedSchool.id}}>
+                  {{school.title}}
+                </option>
+              {{/each}}
+            </select>
+          {{else}}
+            {{this.bestSelectedSchool.title}}
           {{/if}}
-          {{t "general.pendingUpdatesSummaryTitle"}}
-        </h3>
-        <div id="schoolsfilter" class="filter" data-test-schools>
-          <label class="inline-label" for="schools-{{template-id}}">
-            <FaIcon @icon="building-columns" @title={{t "general.school"}} />
-          </label>
-          <div id="school-selection" class="inline-data">
-            {{#if (gt @schools.length 1)}}
-              <select
-                id="schools-{{template-id}}"
-                {{on "change" (pick "target.value" (set this "selectedSchoolId"))}}
-              >
-                {{#each (sortBy "title" @schools) as |school|}}
-                  <option value={{school.id}} selected={{eq school.id this.bestSelectedSchool.id}}>
-                    {{school.title}}
-                  </option>
-                {{/each}}
-              </select>
-            {{else}}
-              {{this.bestSelectedSchool.title}}
-            {{/if}}
-          </div>
         </div>
-        {{#if this.areUpdatesLoaded}}
-          <p data-test-summary>
-            {{t "general.pendingUpdatesSummary" count=(get this.updates "length")}}
-          </p>
-          {{#if (get this.updates "length")}}
-            <div class="actions" data-test-actions>
-              <LinkTo
-                @route="pending-user-updates"
-                @query={{hash school=this.bestSelectedSchool.id}}
-                data-test-manage
-              >
-                <button type="button">
-                  {{t "general.manage"}}
-                </button>
-              </LinkTo>
-            </div>
-          {{/if}}
-        {{else}}
-          <LoadingSpinner />
-        {{/if}}
       </div>
-    {{/let}}
+      {{#if this.areUpdatesLoaded}}
+        <p data-test-summary>
+          {{t "general.pendingUpdatesSummary" count=(get this.updates "length")}}
+        </p>
+        {{#if (get this.updates "length")}}
+          <div class="actions" data-test-actions>
+            <LinkTo
+              @route="pending-user-updates"
+              @query={{hash school=this.bestSelectedSchool.id}}
+              data-test-manage
+            >
+              <button type="button">
+                {{t "general.manage"}}
+              </button>
+            </LinkTo>
+          </div>
+        {{/if}}
+      {{else}}
+        <LoadingSpinner />
+      {{/if}}
+    </div>
   </template>
 }