platform independent build commands (#184)

* Add intellij files to gitignore

* Use node native commands for build scripts

Author: bdurrer

.gitignore

@@ -6,6 +6,7 @@ yarn-error.log
 *~
 *.swp
 .idea
+*.iml
 TODO
 /pages/out
 /pages/generated

package.json

@@ -34,9 +34,10 @@
     "lint:ts": "tslint \"__tests__/**/*.ts\"",
     "lint:js": "eslint \"{__tests__,src,pages/src,pages/lib}/**/*.js\"",
     "format": "prettier --single-quote --trailing-comma=es5 --write \"{__tests__,src,pages/src,pages/lib,perf,resources}/**/*{.js,.ts}\"",
-    "testonly": "./resources/jest.sh",
+    "testonly": "jest --no-cache",
     "test": "run-s format build lint testonly test:types:*",
-    "test:travis": "npm run test && ./resources/check-changes",
+    "check-changes": "node ./resources/check-changes.js",
+    "test:travis": "run-s format build lint \"testonly -i\" test:types:* check-changes",
     "test:types:ts": "tsc ./type-definitions/Immutable.d.ts --lib es2015 && dtslint type-definitions/ts-tests",
     "test:types:flow": "flow check type-definitions/tests --include-warnings",
     "perf": "node ./resources/bench.js",

resources/check-changes

@@ -0,0 +1,29 @@
+/**
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+const { exec } = require('child_process');
+require('colors');
+
+const checkForChanges = () =>
+  new Promise(resolve =>
+    exec(`git diff --quiet`, error => {
+      if (error) {
+        console.log(
+          'The Travis build resulted in additional changed files.'.red
+        );
+        console.log(
+          'Typically this is due to not running "npm test"" locally before submitting a pull request.'
+        );
+        return exec(`git diff --stat`, (diffError, diffOut) => {
+          console.log('\nThe following changes were found:'.red);
+          console.log(diffOut.yellow);
+          process.exit(1);
+        });
+      }
+      resolve();
+    })
+  );
+
+return checkForChanges();

resources/check-changes.js

@@ -5,14 +5,37 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-const path = require('path');
 const { exec } = require('child_process');
+const { deflate } = require('zlib');
+const fs = require('fs');
 
 require('colors');
 
-const execp = cmd =>
+const fileContent = filePath =>
   new Promise((resolve, reject) =>
-    exec(cmd, (error, out) => (error ? reject(error) : resolve(out)))
+    fs.readFile(
+      filePath,
+      (error, out) => (error ? reject(error) : resolve(out))
+    )
+  );
+
+const gitContent = gitPath =>
+  new Promise(resolve =>
+    exec(`git show ${gitPath}`, (error, out) => {
+      if (error) {
+        console.log(
+          `"git show ${gitPath}" failed, resulting in an empty diff.`.yellow
+        );
+        resolve('');
+        return;
+      }
+      resolve(out);
+    })
+  );
+
+const deflateContent = content =>
+  new Promise((resolve, reject) =>
+    deflate(content, (error, out) => (error ? reject(error) : resolve(out)))
   );
 
 const space = (n, s) =>
@@ -29,13 +52,14 @@ const diff = (n, o) => {
 const pct = (s, b) => ` ${Math.floor(10000 * (1 - s / b)) / 100}%`.grey;
 
 Promise.all([
-  execp('cat dist/immutable.js | wc -c'),
-  execp('git show master:dist/immutable.js | wc -c'),
-  execp('cat dist/immutable.min.js | wc -c'),
-  execp('git show master:dist/immutable.min.js | wc -c'),
-  execp('cat dist/immutable.min.js | gzip -c | wc -c'),
-  execp('git show master:dist/immutable.min.js | gzip -c | wc -c'),
+  fileContent('dist/immutable.js'),
+  gitContent('origin/npm:dist/immutable.js'),
+  fileContent('dist/immutable.min.js'),
+  gitContent('origin/npm:dist/immutable.min.js'),
+  fileContent('dist/immutable.min.js').then(deflateContent),
+  gitContent('origin/npm:dist/immutable.min.js').then(deflateContent),
 ])
+  .then(results => results.map(result => Buffer.byteLength(result, 'utf8')))
   .then(results => results.map(result => parseInt(result, 10)))
   .then(([rawNew, rawOld, minNew, minOld, zipNew, zipOld]) => {
     console.log(

resources/dist-stats.js

@@ -295,7 +295,8 @@ function reactPreRender(subDir) {
           '</script>'
       );
     }
-    file.contents = new Buffer(src, enc);
+
+    file.contents = Buffer.from(src, enc);
     this.push(file);
     cb();
   });