Skip to content

Commit 3bb16db

Browse files
committed
build(ui-alerts,console): make documentation preview builds show console logs
INSTUI-4522
1 parent f5941b1 commit 3bb16db

File tree

6 files changed

+20
-3
lines changed

6 files changed

+20
-3
lines changed

.github/workflows/preview.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ jobs:
2424
- name: Build docs-app
2525
run: npm run build:docs
2626
if: github.event.action != 'closed'
27+
env:
28+
GITHUB_PULL_REQUEST_PREVIEW: 'true'
2729
- uses: rossjrw/pr-preview-action@v1
2830
with:
2931
source-dir: ./packages/__docs__/__build__

packages/__docs__/babel.config.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@ module.exports = {
2727
[
2828
require('@instructure/ui-babel-preset'),
2929
{
30-
transformImports: false // needed for webpack reload on change to work,
30+
transformImports: false,
31+
removeConsole: false // needed for webpack reload on change to work,
3132
}
3233
]
3334
]

packages/__docs__/webpack.config.mjs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,12 @@ import { globbySync } from 'globby'
3030
import { merge } from 'webpack-merge'
3131
import { processSingleFile } from './lib/build-docs.mjs'
3232
import resolve from './resolve.mjs'
33+
import webpack from 'webpack'
34+
import TerserPlugin from 'terser-webpack-plugin'
3335

3436
const ENV = process.env.NODE_ENV || 'production'
3537
const DEBUG = process.env.DEBUG || ENV === 'development'
38+
const GITHUB_PULL_REQUEST_PREVIEW = process.env.GITHUB_PULL_REQUEST_PREVIEW || 'false'
3639

3740
const outputPath = resolvePath(import.meta.dirname, '__build__')
3841
const resolveAliases = DEBUG ? { resolve } : {}
@@ -79,6 +82,9 @@ const config = merge(baseConfig, {
7982
template: './src/index.html',
8083
chunks: ['main'],
8184
}),
85+
new webpack.DefinePlugin({
86+
'process.env.GITHUB_PULL_REQUEST_PREVIEW': JSON.stringify(GITHUB_PULL_REQUEST_PREVIEW),
87+
}),
8288
],
8389
optimization: {
8490
usedExports: true,

packages/console/src/console.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,11 @@ function logMessage(
5555
message: string,
5656
...args: unknown[]
5757
) {
58-
if (process.env.NODE_ENV !== 'production' && !condition) {
58+
if (
59+
(process.env.GITHUB_PULL_REQUEST_PREVIEW ||
60+
process.env.NODE_ENV !== 'production') &&
61+
!condition
62+
) {
5963
if (typeof console[level] === 'function') {
6064
const renderStack = withRenderStack ? getRenderStack() : ''
6165
//@ts-expect-error level can be 'constructor' which is not callable

packages/ui-alerts/src/Alert/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,10 +134,11 @@ For more information about live regions, see
134134
return (
135135
<View key={alert.key} display="block" margin="small 0">
136136
<Alert
137+
screenReaderOnly
137138
variant={alert.variant}
138139
renderCloseButtonLabel="Close"
139140
onDismiss={alert.onDismiss}
140-
liveRegion={() => document.getElementById('flash-messages')}
141+
//liveRegion={() => document.getElementById('flash-messages')}
141142
liveRegionPoliteness={alert.politeness}
142143
margin="small 0"
143144
variantScreenReaderLabel={this.getScreenReaderLabel(

packages/ui-alerts/src/Alert/index.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -308,6 +308,9 @@ class Alert extends Component<AlertProps, AlertState> {
308308
}
309309

310310
render() {
311+
// eslint-disable-next-line no-console
312+
console.log('Hello from Alert')
313+
console.warn('Warning from Alert')
311314
const liveRegion = this.getLiveRegion()
312315
const screenReaderContent = liveRegion
313316
? this.createScreenReaderPortal(liveRegion)

0 commit comments

Comments
 (0)