refactor: Fixes #4578 #4938
refactor: Fixes #4578 #4938
Conversation
… unknown or a metrics_id)
.pre-commit-config.yaml
Outdated
| - id: pyupgrade | ||
| exclude: ^fuzz/generated/ | ||
| args: ["--py38-plus"] | ||
| args: ["--py312-plus"] |
There was a problem hiding this comment.
| args: ["--py312-plus"] | |
| args: ["--py39-plus"] |
We actually do want to keep this at py39-plus since we still support python 3.9. This may result in you having to make some other fixes below.
terriko
left a comment
terriko
left a comment
There was a problem hiding this comment.
Looks like dev-requirements.txt got a bit messed up, probably because this PR is old and there's been some other changes in there (both version bumps and alphabetization), but I don't want to revert a bunch of versions. Can you take that file out of this PR and we'll deal with taking out the < 3.8 stuff some other time? It's either that or rebase and then manually fix it, but I'm pretty sure it'll be easier to just do it separately.
|
Yeah sure thing 👍 |
|
I think it should be good now |
|
Updating the branch for the tests; sorry this one fell off my radar! |
3 participants
Removed python 3.8 support.
Happy to make any changes if are required.
Thanks