Skip to content

Commit 00ae3dd

Browse files
authored
[Benchmark] Fix logging in compare.py (#19408)
The introduction of logger to compare.py broke logging altogether: This PR fixes it.
1 parent 23a73ce commit 00ae3dd

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

devops/scripts/benchmarks/compare.py

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -350,9 +350,8 @@ def to_hist(
350350

351351
args = parser.parse_args()
352352

353-
if args.verbose:
354-
verbose = True
355-
log.info("-- Compare.py --")
353+
log.initialize(args.verbose)
354+
log.info("-- Compare.py --")
356355

357356
if args.operation == "to_hist":
358357
if not Validate.timestamp(args.cutoff):
@@ -392,19 +391,25 @@ def print_regression(entry: dict, is_warning: bool = False):
392391
log_func("")
393392

394393
if improvements:
395-
log.info("#\n# Improvements:\n#\n")
394+
log.info("#")
395+
log.info("# Improvements:")
396+
log.info("#")
396397
for test in improvements:
397398
print_regression(test)
398399
if regressions_ignored:
399-
log.info("#\n# Regressions (filtered out by regression-filter):\n#\n")
400+
log.info("#")
401+
log.info("# Regressions (filtered out by regression-filter):")
402+
log.info("#")
400403
for test in regressions_ignored:
401404
print_regression(test)
402405
if regressions_of_concern:
403-
log.warning("#\n# Regressions:\n#\n")
406+
log.warning("#")
407+
log.warning("# Regressions:")
408+
log.warning("#")
404409
for test in regressions_of_concern:
405410
print_regression(test, is_warning=True)
406411
exit(1) # Exit 1 to trigger github test failure
407-
log.info("\nNo unexpected regressions found!")
412+
log.info("No unexpected regressions found!")
408413
else:
409414
log.error("Unsupported operation: exiting.")
410415
exit(1)

0 commit comments

Comments
 (0)