[UR][L0] Fix UR_PROGRAM_INFO_BINARIES query #19415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
againull
force-pushed
the
ur_program_info_binaries
branch
from
45078e5 to
736967c
Compare
againull
force-pushed
the
ur_program_info_binaries
branch
from
736967c to
d4d54b8
Compare
nrspruit
approved these changes
Jul 14, 2025
Contributor
nrspruit
left a comment
nrspruit
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the patch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of the value returned from UR_PROGRAM_INFO_BINARIES query was incorrect, we need to return the size of array of pointers (for each device associated with the program) according to doc:
https://oneapi-src.github.io/unified-runtime/core/api.html?highlight=urprogramgetinfo#ur-program-info-t
This bug was leading to crashes when using persistent cache in sycl in scenarios with multi-device context, newly added test emulates that scenario when we recreate program from the saved binary.