Skip to content

Commit e7fec65

Browse files
committed
Fixed reactive lists issues
1 parent 65106ec commit e7fec65

File tree

17 files changed

+31
-23
lines changed

17 files changed

+31
-23
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "1.0.11-prealpha",
2+
"version": "1.0.12-prealpha",
33
"description": "",
44
"main": "index.ts",
55
"type": "module",

packages/create-puls/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "create-pulsjs",
3-
"version": "1.0.11-prealpha",
3+
"version": "1.0.12-prealpha",
44
"main": "dist/index.js",
55
"scripts": {
66
"test": "echo \"Error: no test specified\" && exit 1",

packages/create-puls/template-js/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@
1212
"vite": "^6.1.0"
1313
},
1414
"dependencies": {
15-
"pulsjs": "1.0.11-prealpha"
15+
"pulsjs": "1.0.12-prealpha"
1616
}
1717
}

packages/create-puls/template-ts/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@
1313
"vite": "^6.1.0"
1414
},
1515
"dependencies": {
16-
"pulsjs": "1.0.11-prealpha"
16+
"pulsjs": "1.0.12-prealpha"
1717
}
1818
}

packages/puls-adapter/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "pulsjs-adapter",
3-
"version": "1.0.11-prealpha",
3+
"version": "1.0.12-prealpha",
44
"scripts": {
55
"test": "echo \"Error: no test specified\" && exit 1"
66
},

packages/puls-compiler/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "pulsjs-compiler",
3-
"version": "1.0.11-prealpha",
3+
"version": "1.0.12-prealpha",
44
"description": "",
55
"main": "dist/index.js",
66
"scripts": {

packages/puls-css/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "pulsjs-css",
3-
"version": "1.0.11-prealpha",
3+
"version": "1.0.12-prealpha",
44
"scripts": {
55
"test": "echo \"Error: no test specified\" && exit 1"
66
},

packages/puls-dom-adapter/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "pulsjs-dom-adapter",
3-
"version": "1.0.11-prealpha",
3+
"version": "1.0.12-prealpha",
44
"scripts": {
55
"test": "echo \"Error: no test specified\" && exit 1"
66
},

packages/puls-dom-adapter/src/PulsDOMAdapter.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -423,26 +423,26 @@ export class PulsDOMAdapter extends PulsAdapter<Node[]>{
423423
this.afterElement(el, e)
424424
el = e
425425

426+
// TODO Fix reactive list bugs
426427
const addReplaceListener = (toRepl: ChildNode) => {
427428
const events = new Map<string, any>()
428429
events.set(':replace_with', ({detail: {from, to}}: any) => {
429-
console.count()
430-
console.log(from, to)
431-
events.forEach((value, key) => toRepl.removeEventListener(key, value as any))
432430
for (const innerEl of to) {
433-
if (!elements.includes(innerEl)) {
434-
elements.push(innerEl)
431+
if (!from.includes(innerEl)) {
435432
addReplaceListener(innerEl)
436433
}
437434
}
438435
})
439436

440437
events.set(':detached', () => {
441-
events.forEach((value, key) => toRepl.removeEventListener(key, value as any))
442-
elements.splice(elements.findIndex(el => el === toRepl), 1)
438+
const isEl = elements.findIndex(el => el === toRepl)
439+
440+
if (isEl !== -1) {
441+
events.forEach((value, key) => toRepl.removeEventListener(key, value as any))
442+
elements.splice(isEl, 1)
443+
}
443444
})
444445
events.set(':attached', () => {
445-
events.forEach((value, key) => toRepl.removeEventListener(key, value as any))
446446
if (!elements.includes(toRepl)) {
447447
elements.push(toRepl)
448448
}

packages/puls-jsx/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "pulsjs-jsx",
3-
"version": "1.0.11-prealpha",
3+
"version": "1.0.12-prealpha",
44
"description": "",
55
"main": "dist/index.js",
66
"scripts": {

0 commit comments

Comments
 (0)