Fix pagination for FindAll method #427
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FindAllmethod was returning on the wrong results when using pagination.The
$pageNumberargument was being passed directly to the query as thestartPositioninstead of determining what thestartPositionshould be based on the$pageNumberand$pageSize.This PR determines the correct
startPositionfor the query.The
$pageNumberargument default has been updated to1since that makes more sense. When thinking about pages we think of them as starting at 1 not 0.Example
Say you had 25 items and were wanting to return them all in pages of 10.
Page 0
Result:
Expected:
(this is redundant and the same as page 1)
Page 1
Result:
Expected:
Page 2
Result:
Expected:
Page 3
Result:
Expected: