Skip to content

Space needed between multiple name identifiers #306

@phette23

Description

@phette23

Package version (if known): HEAD (seen on [email protected])

Describe the bug

When a name has multiple identifiers, they are sometimes combined with no space in between. This is visually unpleasing but also breaks screenreaders since they're reading not the identifier but the identifier with the next identifiers scheme postfixed.

Steps to Reproduce

  1. Create a name with multiple identifiers not in the list of makeIdEntry cases (orcid, gnd, ror, isni, grid), example:
- affiliations:
  - id: 01mmcf932
  family_name: Phetteplace
  given_name: Eric
  id: https://portal.cca.edu/people/ephetteplace/
  identifiers:
  - identifier: https://portal.cca.edu/people/ephetteplace/
    scheme: url
  - identifier: [email protected]
    scheme: email
  1. Go to the deposit form
  2. Add a Creator or Contributor
  3. Search for a string that will bring up the name, e.g. "Phetteplace"
  4. The two id strings are stuck together: url: https://portal.cca.edu/people/ephetteplace/email: [email protected]

Expected behavior

There should be a space in between each identifier and the scheme of the following one: url: https://portal.cca.edu/people/ephetteplace/ email: [email protected]

Screenshots (if applicable)

Image

Additional context

This occurs in src/lib/elements/contrib/invenioRDM/records/AffiliationsSuggestions.js and could be fixed in either the makeIdEntry or AffiliationsSuggestions functions. I will submit a small PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions