[fix]: Prevent multiple publishes of alias states if subscribed more than once (#2757)

* Adde letsencrypt shim

* exported session so adapters can use it like before after ESM port

* prevent double publish

* added test

* make the le shim true instead of null

* move stop in progress check up

* rm test log

* fix path on cmdExec

* fix paths to iobroker.js

Author: foxriver76

packages/adapter/src/lib/adapter/adapter.ts

@@ -10969,11 +10969,22 @@ export class AdapterClass extends EventEmitter {
                             }
                         }
                     }
-                } else if (this.adapterReady && this.aliases.has(id)) {
+                } else if (!this._stopInProgress && this.adapterReady && this.aliases.has(id)) {
                     // If adapter is ready and for this ID exist some alias links
                     const alias = this.aliases.get(id);
-                    alias!.targets.forEach(target => {
+                    /** Prevent multiple publishes if multiple pattern contain this alias id */
+                    const uniqueTargets = new Set<string>();
+
+                    for (const target of alias!.targets) {
+                        const targetId = target.id;
+                        if (uniqueTargets.has(targetId)) {
+                            continue;
+                        }
+
+                        uniqueTargets.add(targetId);
+
                         const source = alias!.source!;
+
                         const aState = state
                             ? tools.formatAliasValue({
                                   sourceCommon: source,
@@ -10982,21 +10993,19 @@ export class AdapterClass extends EventEmitter {
                                   logger: this._logger,
                                   logNamespace: this.namespaceLog,
                                   sourceId: id,
-                                  targetId: target.id
+                                  targetId
                               })
                             : null;
 
-                        const targetId = target.id;
-
-                        if (!this._stopInProgress && (aState || !state)) {
+                        if (aState || !state) {
                             if (typeof this._options.stateChange === 'function') {
                                 this._options.stateChange(targetId, aState);
                             } else {
                                 // emit 'stateChange' event instantly
                                 setImmediate(() => this.emit('stateChange', targetId, aState));
                             }
                         }
-                    });
+                    }
                 }
             },
             changeUser: (id, state) => {

packages/common/src/index.ts

@@ -8,4 +8,4 @@ export * as constants from '@/lib/common/constants.js';
 export { createAdapterStore as session } from '@/lib/common/session.js';
 
 /** This is a backward compatibility shim, if all adapters are on adapter-core 2.6.11 or 3.1.4 remove this */
-export const letsencrypt = null;
+export const letsencrypt = true;

packages/controller/src/main.ts

@@ -1996,7 +1996,7 @@ async function processMessage(msg: ioBroker.SendableMessage): Promise<null | voi
             break;
 
         case 'cmdExec': {
-            const mainFile = path.join(thisDir, '..', `${tools.appName.toLowerCase()}.js`);
+            const mainFile = path.join(tools.getControllerDir(), `${tools.appName.toLowerCase()}.js`);
             const args = [...getDefaultNodeArgs(mainFile), mainFile];
             if (!msg.message.data || typeof msg.message.data !== 'string') {
                 logger.warn(
@@ -3436,7 +3436,7 @@ function installAdapters(): void {
             );
         }
 
-        const mainFile = path.join(thisDir, '..', `${tools.appName.toLowerCase()}.js`);
+        const mainFile = path.join(tools.getControllerDir(), `${tools.appName.toLowerCase()}.js`);
         const installArgs = [];
         const installOptions = { windowsHide: true };
         if (!task.rebuild && task.installedFrom && proc.downloadRetry < 3) {
@@ -3543,7 +3543,7 @@ function installAdapters(): void {
             });
             child.on('error', err => {
                 logger.error(
-                    `${hostLogPrefix} Cannot execute "${thisDir}/${tools.appName.toLowerCase()}.js ${commandScope} ${name}: ${
+                    `${hostLogPrefix} Cannot execute "${tools.getControllerDir()}/${tools.appName.toLowerCase()}.js ${commandScope} ${name}: ${
                         err.message
                     }`
                 );
@@ -3554,7 +3554,7 @@ function installAdapters(): void {
             });
         } catch (err) {
             logger.error(
-                `${hostLogPrefix} Cannot execute "${thisDir}/${tools.appName.toLowerCase()}.js ${commandScope} ${name}: ${err}`
+                `${hostLogPrefix} Cannot execute "${tools.getControllerDir()}/${tools.appName.toLowerCase()}.js ${commandScope} ${name}: ${err}`
             );
             setTimeout(() => {
                 installQueue.shift();

packages/controller/test/lib/testAliases.ts

@@ -1,6 +1,7 @@
 import type { TestContext } from '../_Types.js';
 import type { Client as ObjectsInRedisClient } from '@iobroker/db-objects-redis';
 import { PERMISSIONS } from './permissions.js';
+import { setTimeout as wait } from 'node:timers/promises';
 
 async function prepareGroupsAndUsers(objects: ObjectsInRedisClient): Promise<void> {
     await objects.setObject('system.group.userC', {
@@ -492,6 +493,26 @@ export function register(it: Mocha.TestFunction, expect: Chai.ExpectStatic, cont
         });
     }).timeout(3_000);
 
+    // Avoid Issue 2753
+    it(testName + 'Test subscribe alias multiple times should only publish once', async () => {
+        let noTriggered = 0;
+
+        context.onAdapterStateChanged = (id, state) => {
+            if (id === gAliasID) {
+                expect(state).to.be.ok;
+                noTriggered++;
+            }
+        };
+
+        await context.adapter.subscribeForeignStatesAsync(gAliasID);
+        await context.adapter.subscribeForeignStatesAsync(gAliasID);
+
+        await context.states.setState(gid, 10);
+        await wait(500);
+
+        expect(noTriggered).to.equal(1);
+    }).timeout(3_000);
+
     it(testName + 'Test negative subscribe aliases regex', done => {
         const parts = gAliasID.split('.');
         parts.pop();