[fix]: another fix for GH dependencies by adapters (#2803)

* prepare changelog for beta

* allow to install github urls too

* add to docs

* fix the validation log

* trim output from npm view

* fix linter

* listInstalledNodeModules now returns correct name also for GitHub dependencies

* request module name as determining package json is not trivial in all cases

Author: foxriver76

CHANGELOG.md

@@ -4,7 +4,7 @@
 	## __WORK IN PROGRESS__
 -->
 
-## 6.0.3 (2024-06-12) - Kiera
+## __WORK IN PROGRESS__ - Kiera
 
 **Breaking changes**
 * Support for Node.js 16 is dropped!

packages/adapter/src/lib/adapter/utils.ts

@@ -10,10 +10,6 @@ import {
 import { SUPPORTED_FEATURES, type SupportedFeature } from '@/lib/adapter/constants.js';
 import path from 'node:path';
 import fs from 'fs-extra';
-import { createRequire } from 'node:module';
-
-// eslint-disable-next-line unicorn/prefer-module
-const require = createRequire(import.meta.url || 'file://' + __filename);
 
 interface EncryptArrayOptions {
     /** The objects whose values should be en/decrypted */
@@ -118,15 +114,20 @@ export async function listInstalledNodeModules(namespace: string): Promise<strin
     };
     const dependencies: string[] = [];
 
-    for (const dependency of Object.keys(packJson.dependencies)) {
+    for (const [dependency, versionInfo] of Object.entries(packJson.dependencies)) {
         if (!dependency.startsWith(`@${appNameLowerCase}-${namespace}/`)) {
             continue;
         }
 
-        const packPath = require.resolve(`${dependency}/package.json`);
-        const packJson = await fs.readJson(packPath);
+        let realDependencyName: string;
+        // remove npm: and version after last @
+        if (versionInfo.startsWith('npm:')) {
+            realDependencyName = versionInfo.substring(4, versionInfo.lastIndexOf('@'));
+        } else {
+            realDependencyName = await requestModuleNameByUrl(versionInfo);
+        }
 
-        dependencies.push(packJson.name);
+        dependencies.push(realDependencyName);
     }
 
     return dependencies;

packages/common-db/README.md

@@ -1,6 +1,5 @@
 # Common DB class for ioBroker
-The Library contains the common utils of ioBroker which use the DB directly and thus cannot be required by the DB itself (cirular dependencies).
-It makes sense to place methods here too, which require typings from the database if they are surely not used by the database.
+The Library contains the common utils for the ioBroker controller which can be used by db classes too, as they do not rely on the db (circular dependencies).
 
 ## License
 MIT

packages/common/README.md

@@ -1,5 +1,6 @@
 # Common class for ioBroker
-The Library contains the common utils for the ioBroker controller.
+The Library contains the common utils of ioBroker which use the DB directly and thus cannot be required by the DB itself (cirular dependencies).
+It makes sense to place methods here too, which require typings from the database if they are surely not used by the database.
 
 ## License
 MIT