Skip to content

46223 Add missing step to apply destination rules after running virtual services #13655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bedla wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

46223 Add missing step to apply destination rules after running virtual services #13655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/en/docs/setup/getting-started/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ Follow these steps to get started with Istio:

## Deploy the sample application {#bookinfo}

1. Deploy the [`Bookinfo` sample application](/docs/examples/bookinfo/):
1. Follow steps in the page [`Bookinfo` sample application](/docs/examples/bookinfo/) to deploy sample application:
Copy link
Collaborator

@frankbu frankbu Jul 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to change the getting started page to tell users to go to another document to do things. The getting started doc is supposed to be a simple, self contained, set of instructions to make it easy for users to start looking at Istio.

I see why the current request-routing instructions are a little confusing (hidden). My suggestion would be to remove the warning on line 46 and put the warning under each tab (Istio APIs and Gateway API) instead.

Then you can change the wording under the Istio APIs tab to make it clear that it's asking you to create the destination rules:

If you haven’t already applied destination rules, follow the instructions in [define the service versions](/docs/examples/bookinfo/#define-the-service-versions).


{{< text bash >}}
$ kubectl apply -f @samples/bookinfo/platform/kube/bookinfo.yaml@
Expand Down