Merge pull request #17275 from iterate-ch/bugfix/MD-23962

Save passwords regardless of missing username.

Author: dkocher

core/src/main/java/ch/cyberduck/core/DefaultHostPasswordStore.java

@@ -49,7 +49,9 @@ public String findLoginPassword(final Host bookmark) {
         final String password;
         try {
             password = this.getPassword(bookmark.getProtocol().getScheme(), bookmark.getPort(),
-                    bookmark.getHostname(), credentials.getUsername());
+                    bookmark.getHostname(), StringUtils.isEmpty(credentials.getUsername()) ?
+                            bookmark.getProtocol().getPasswordPlaceholder() :
+                            String.format("%s (%s)", bookmark.getProtocol().getPasswordPlaceholder(), credentials.getUsername()));
         }
         catch(LocalAccessDeniedException e) {
             log.warn("Failure {} searching in keychain", e.getMessage());
@@ -74,7 +76,8 @@ public String findLoginToken(final Host bookmark) {
         try {
             token = this.getPassword(bookmark.getProtocol().getScheme(), bookmark.getPort(),
                     bookmark.getHostname(), StringUtils.isEmpty(credentials.getUsername()) ?
-                            bookmark.getProtocol().getTokenPlaceholder() : String.format("%s (%s)", bookmark.getProtocol().getTokenPlaceholder(), credentials.getUsername()));
+                            bookmark.getProtocol().getTokenPlaceholder() :
+                            String.format("%s (%s)", bookmark.getProtocol().getTokenPlaceholder(), credentials.getUsername()));
         }
         catch(LocalAccessDeniedException e) {
             log.warn("Failure {} searching in keychain", e.getMessage());
@@ -218,12 +221,9 @@ public void save(final Host bookmark) throws LocalAccessDeniedException {
                 log.warn("No username in credentials for bookmark {}", bookmark.getHostname());
                 return;
             }
-            if(StringUtils.isEmpty(credentials.getPassword())) {
-                log.warn("No password in credentials for bookmark {}", bookmark.getHostname());
-                return;
-            }
             this.addPassword(protocol.getScheme(), bookmark.getPort(),
-                    bookmark.getHostname(), credentials.getUsername(), credentials.getPassword());
+                    bookmark.getHostname(), StringUtils.isEmpty(credentials.getUsername()) ?
+                            protocol.getPasswordPlaceholder() : String.format("%s (%s)", protocol.getPasswordPlaceholder(), credentials.getUsername()), credentials.getPassword());
         }
         if(credentials.isTokenAuthentication()) {
             this.addPassword(protocol.getScheme(), bookmark.getPort(),