Fixes #5410 (#5413)

Author: STRd6

docs/v2/annotated-source/nodes.html

@@ -9719,7 +9719,7 @@ <h3 id="for">For</h3>
         {index: ivar, name, @step, shouldCache: shouldCacheOrIsAssignable}
     <span class="hljs-keyword">else</span>
       svar    = @source.compile o, LEVEL_LIST
-      <span class="hljs-keyword">if</span> (name <span class="hljs-keyword">or</span> @own) <span class="hljs-keyword">and</span> @source.unwrap() <span class="hljs-keyword">not</span> <span class="hljs-keyword">instanceof</span> IdentifierLiteral
+      <span class="hljs-keyword">if</span> (name <span class="hljs-keyword">or</span> @own) <span class="hljs-keyword">and</span> <span class="hljs-keyword">not</span> @from <span class="hljs-keyword">and</span> @source.unwrap() <span class="hljs-keyword">not</span> <span class="hljs-keyword">instanceof</span> IdentifierLiteral
         defPart    += <span class="hljs-string">&quot;<span class="hljs-subst">#{@tab}</span><span class="hljs-subst">#{ref = scope.freeVariable <span class="hljs-string">&#x27;ref&#x27;</span>}</span> = <span class="hljs-subst">#{svar}</span>;\n&quot;</span>
         svar       = ref
       <span class="hljs-keyword">if</span> name <span class="hljs-keyword">and</span> <span class="hljs-keyword">not</span> @pattern <span class="hljs-keyword">and</span> <span class="hljs-keyword">not</span> @from

docs/v2/browser-compiler-legacy/coffeescript.js

@@ -3469,10 +3469,9 @@ <h2>Generator Functions</h2>
 };
 
 getFibonacciNumbers = function(length) {
-  var n, ref, results;
+  var n, results;
   results = [1];
-  ref = fibonacci();
-  for (n of ref) {
+  for (n of fibonacci()) {
     results.push(n);
     if (results.length === length) {
       break;
@@ -3493,10 +3492,9 @@ <h2>Generator Functions</h2>
 };
 
 <span class="cm-variable">getFibonacciNumbers</span> <span class="cm-operator">=</span> <span class="cm-keyword">function</span>(<span class="cm-def">length</span>) {
-  <span class="cm-keyword">var</span> <span class="cm-def">n</span>, <span class="cm-def">ref</span>, <span class="cm-def">results</span>;
+  <span class="cm-keyword">var</span> <span class="cm-def">n</span>, <span class="cm-def">results</span>;
   <span class="cm-variable-2">results</span> <span class="cm-operator">=</span> [<span class="cm-number">1</span>];
-  <span class="cm-variable-2">ref</span> <span class="cm-operator">=</span> <span class="cm-variable">fibonacci</span>();
-  <span class="cm-keyword">for</span> (<span class="cm-variable-2">n</span> <span class="cm-keyword">of</span> <span class="cm-variable-2">ref</span>) {
+  <span class="cm-keyword">for</span> (<span class="cm-variable-2">n</span> <span class="cm-keyword">of</span> <span class="cm-variable">fibonacci</span>()) {
     <span class="cm-variable-2">results</span>.<span class="cm-property">push</span>(<span class="cm-variable-2">n</span>);
     <span class="cm-keyword">if</span> (<span class="cm-variable-2">results</span>.<span class="cm-property">length</span> <span class="cm-operator">===</span> <span class="cm-variable-2">length</span>) {
       <span class="cm-keyword">break</span>;

docs/v2/browser-compiler-modern/coffeescript.js

@@ -19736,6 +19736,14 @@ <h1>CoffeeScript Test Suite</h1>
     throw new Error "DOOM was called with a null element" unless elm? for elm in elms
   """
 
+test "#5410: for from loops shouldn't make excess refs", ->
+  js = CoffeeScript.compile """
+    for x from fn()
+      alert x
+  """
+
+  ok !js.match /ref/
+
 </script>
 <script type="text/x-coffeescript" class="test" id="control_flow">
 # Control Flow

docs/v2/index.html

@@ -5418,7 +5418,7 @@ exports.For = class For extends While
         {index: ivar, name, @step, shouldCache: shouldCacheOrIsAssignable}
     else
       svar    = @source.compile o, LEVEL_LIST
-      if (name or @own) and @source.unwrap() not instanceof IdentifierLiteral
+      if (name or @own) and not @from and @source.unwrap() not instanceof IdentifierLiteral
         defPart    += "#{@tab}#{ref = scope.freeVariable 'ref'} = #{svar};\n"
         svar       = ref
       if name and not @pattern and not @from

docs/v2/test.html

@@ -618,3 +618,11 @@ test "#5309: comprehension as postfix condition", ->
   doesNotThrowCompileError """
     throw new Error "DOOM was called with a null element" unless elm? for elm in elms
   """
+
+test "#5410: for from loops shouldn't make excess refs", ->
+  js = CoffeeScript.compile """
+    for x from fn()
+      alert x
+  """
+
+  ok !js.match /ref/