feat: build deepseek v2 decoder layer and related model files for mlu device. #373
+1,708
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuZhang99
reviewed
Nov 13, 2025
xllm/models/llm/mlu/deepseek_v2.h
Outdated
| int32_t dp_local_tp_size_; | ||
| int32_t num_experts_per_tok_; | ||
| int32_t num_speculative_tokens_ = 0; | ||
| at::Device device_; |
Contributor
There was a problem hiding this comment.
I have removed those useless variables due to my unwary copying from xllm/models/llm/deepseek_v2.h
xllm/models/llm/mlu/deepseek_v2.h
Outdated
| #include <gflags/gflags.h> | ||
| #include <torch/torch.h> | ||
|
|
||
| #include <boost/algorithm/string.hpp> |
|
|
||
| #include <torch/torch.h> | ||
|
|
||
| #include <functional> |
| /*num_experts=*/model_args.n_routed_experts(), | ||
| /*top_k=*/model_args.num_experts_per_tok(), | ||
| /*num_expert_group=*/model_args.n_group(), | ||
| /*topk_group=*/model_args.topk_group(), |
Collaborator
There was a problem hiding this comment.
no need to add such comments for these var.
xllm/core/layers/common/dense_mlp.h
Outdated
| bool is_gated, | ||
| bool has_bias, | ||
| const std::string& hidden_act, | ||
| bool if_reduce_results, |
Collaborator
There was a problem hiding this comment.
nit: use bool enable_result_reduction.
XuZhang99
reviewed
Nov 13, 2025
xllm/models/llm/mlu/deepseek_v2.h
Outdated
| ==============================================================================*/ | ||
| #pragma once | ||
|
|
||
| #include <gflags/gflags.h> |
XuZhang99
changed the title
XuZhang99
changed the title
a120092009
force-pushed
the
mlu/feat_deepseek_layer
branch
from
d83692b to
b2f779c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.