PGTK issue: doesn't look like expected on my setup

[magthe]

This is what the defaults look like for me (zoomed in a bit):

My config:

(use-package indent-bars
  :straight (:host github
             :repo "jdtsmith/indent-bars")
  :hook ((haskell-mode python-mode yaml-mode) . indent-bars-mode))

I seem to have stipple support, but maybe it's broken?

(set-face-stipple 'default (,(window-font-width) 1 ,(unibyte-string 1)))` gives the following error

Debugger entered--Lisp error: (error "Invalid stipple attribute" 23 1 "\1")
  set-face-attribute(default nil :stipple (23 1 "\1"))
  set-face-stipple(default (23 1 "\1"))
  eval-expression((set-face-stipple 'default `(,(window-font-width) 1 ,(unibyte-string 1))) nil nil 127)
  funcall-interactively(eval-expression (set-face-stipple 'default `(,(window-font-width) 1 ,(unibyte-string 1))) nil nil 127)
  command-execute(eval-expression)

I'm not sure what that means really.

[jdtsmith]

I see, so it is working, just looks different. I bet it is the theme after all. How do your outline-* faces look? M-x list-faces-display. I suspect they have background set in this manner. If so, just add :face-bg t to indent-bars-color-by-depth, checking that variable doc for more info.

For the other error, for this large of a character width, you need 3 bytes! I updated the test code; please give a try.

[jdtsmith]

Also, C-h v indent-bars-color-by-depth and show the value.

[magthe]

The outline faces:

and

indent-bars-color-by-depth: (:regexp "outline-\\([0-9]+\\)" :blend 1)

also, trying the updated test code gives me a window that looks like this

The theme I'm using is Nord from doom themes.

[skrat]

Same issue here. Also doomed.

[magthe]

Actually it doesn't look right with the default theme either:

Could Wayland or GTK3 be to blame?

[sauvala]

Same issue for me. I tried with my vanilla Emacs (on Linux + Wayland) config with different themes but there was always that “wider background” color of the indentation marks that did not match my theme’s color.

[jdtsmith]

Huh, interesting. Yeah, thinking about it more, there is no background specified (except for the current depth highlight, if you have :background set). So it's unclear why "stipple + face foreground color = inverse". Can you all try the stipple test code in a plain scratch buffer and post images of results? @magthe what is up with those colored blocks? Are those text?

For me the test looks like:

[jdtsmith]

Also, everyone post their version, please. All Wayland?

[magthe]

@magthe what is up with those colored blocks? Are those text?

Yes, that would by due to rainbow-delimiters. When it's turned off it looks like this when I run the stipple test code.

[magthe]

Version and build options:

GNU Emacs 30.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.17.8) of 2023-07-26

--prefix=/usr
--sysconfdir=/etc
--libexecdir=/usr/lib
--localstatedir=/var
--mandir=/usr/share/man
--with-gameuser=:games
--with-modules
--without-libotf
--without-m17n-flt
--without-gconf
--with-native-compilation=yes
--with-native-compilation=aot
--with-xinput2
--with-pgtk
--without-xaw3d
--with-sound=no
--with-xwidgets
--with-tree-sitter
--without-compress-install
'--program-transform-name=s/\\([ec]tags\\)/\\1.emacs/'
'CFLAGS=-march=x86-64
-mtune=generic
-O2
-pipe
-fno-plt
-fexceptions
-Wp,-D_FORTIFY_SOURCE=2
-Wformat
-Werror=format-security
-fstack-clash-protection
-fcf-protection'
LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now
'CXXFLAGS=-march=x86-64
-mtune=generic
-O2
-pipe
-fno-plt
-fexceptions
-Wp,-D_FORTIFY_SOURCE=2
-Wformat
-Werror=format-security
-fstack-clash-protection
-fcf-protection
-Wp,-D_GLIBCXX_ASSERTIONS'

[jdtsmith]

I see, now I can see the "inverse text" just barely peeking through there in your image. Needless to say, this is not how a stipple is supposed to look (it was invented as a "cheap shading option" in the monochrome days). This seems to draw the inverse of overlaying a stipple. I.e. it uses the stipple as a mask and only lets through data in those regions.

This is looking more to me like a display bug in whichever version you are all using; please report that with M-x emacs-report-bug.

[jdtsmith]

Thanks for the info: --with-pgtk means Wayland right (not on Linux anymore)? @sauvala , @skrat ? Also, let me know if you can test on a non-Wayland version.

[skrat]

@jdtsmith ---with-pgtk doesn't mean Wayland, it means Pure GTK. This is Emacs rendering engine, and it's been merged to master, the old X11 stuff is no longer being developed. It's now role of GTK to manage the windows and handle the rendering. And yes, that's what I'm running along with native compilation.

[jdtsmith]

OK, it seems clear that Pure GTK emacs incorrectly displays stipples. I'd suggest reporting that with M-x report-emacs-bug; feel free to use my test code for this. I'll document it, but not sure I can do much unless someone has a trick to enable correct stipple display. Will leave open for a bit to see.

[jdtsmith]

You can also try this simpler test:

(let* ((w (window-font-width))
       (stipple `(,w 1 ,(apply #'unibyte-string
			       (append (make-list (1- (/ (+ w 7) 8)) ?\0)
				       '(1))))))
  (insert "\n" (propertize (concat  (make-string 15 ?\s)
				    "THIS IS A TEST"
				    (make-string 15 ?\s))
                           'face `(:background "red" :foreground "blue" :stipple ,stipple))))

Should look like: