chore: use @typescript-eslint v8 in development (#1757)

* chore: use v8 for `@typescript-eslint` in development

* refactor: make typescript happy

* chore: add types for removed properties on interface

Author: G-Rath

package.json

@@ -85,9 +85,9 @@
     "@types/jest": "^29.0.0",
     "@types/node": "^16.0.0",
     "@types/semver": "^7.5.8",
-    "@typescript-eslint/eslint-plugin": "^7.0.0",
-    "@typescript-eslint/parser": "^7.0.0",
-    "@typescript-eslint/utils": "^7.0.0",
+    "@typescript-eslint/eslint-plugin": "^8.0.0",
+    "@typescript-eslint/parser": "^8.0.0",
+    "@typescript-eslint/utils": "^8.0.0",
     "babel-jest": "^29.0.0",
     "babel-plugin-replace-ts-export-assignment": "^0.0.2",
     "dedent": "^1.5.0",

src/rules/prefer-importing-jest-globals.ts

@@ -117,7 +117,8 @@ export default createRule({
             if (importNode?.type === AST_NODE_TYPES.ImportDeclaration) {
               for (const specifier of importNode.specifiers) {
                 if (specifier.type === AST_NODE_TYPES.ImportSpecifier) {
-                  let importName = specifier.imported.name ?? '';
+                  let importName =
+                    'name' in specifier.imported ? specifier.imported.name : '';
                   const local = getAccessorValue(specifier.local);
 
                   if (local !== importName) {

src/rules/unbound-method.ts

@@ -48,6 +48,14 @@ export type MessageIds = 'unbound' | 'unboundWithoutThisAnnotation';
 
 const DEFAULT_MESSAGE = 'This rule requires `@typescript-eslint/eslint-plugin`';
 
+// todo: remove these along with the actual runtime properties below in new major
+declare module '@typescript-eslint/utils/ts-eslint' {
+  interface RuleMetaDataDocs {
+    requiresTypeChecking?: boolean;
+    recommended?: unknown;
+  }
+}
+
 export default createRule<Options, MessageIds>({
   defaultOptions: [{ ignoreStatic: false }],
   ...baseRule,

src/rules/utils/parseJestFnCall.ts

@@ -452,15 +452,12 @@ const describeImportDefAsImport = (
     return null;
   }
 
-  let imported = def.node.imported.name ?? '';
-
-  if ('value' in def.node.imported) {
-    imported = def.node.imported.value as string;
-  }
-
   return {
     source: def.parent.source.value,
-    imported,
+    imported:
+      'name' in def.node.imported
+        ? def.node.imported.name
+        : def.node.imported.value,
     local: def.node.local.name,
   };
 };