Skip to content

Commit 866b3af

Browse files
authored
Merge pull request #177 from jonycheung/codex/locate-and-fix-important-bug
Fix hidden file compilation with includeHidden flag
2 parents f384c1f + d891b26 commit 866b3af

File tree

3 files changed

+18
-4
lines changed

3 files changed

+18
-4
lines changed

src/less-watch-compiler.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ function init(){
6666
if (programOption.sourceMap) lessWatchCompilerUtils.config.sourceMap = programOption.sourceMap;
6767
if (programOption.plugins) lessWatchCompilerUtils.config.plugins = programOption.plugins;
6868
if (programOption.runOnce) lessWatchCompilerUtils.config.runOnce = programOption.runOnce;
69-
if (programOption.inludeHidden) lessWatchCompilerUtils.config.includeHidden = programOption.includeHidden;
69+
if (programOption.includeHidden) lessWatchCompilerUtils.config.includeHidden = programOption.includeHidden;
7070
if (programOption.enableJs) lessWatchCompilerUtils.config.enableJs = programOption.enableJs;
7171
if (programOption.lessArgs) lessWatchCompilerUtils.config.lessArgs = programOption.lessArgs;
7272

src/lib/lessWatchCompilerUtils.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,8 @@ define(function (require) {
9696

9797
var outputFilePath = this.resolveOutputPath(file);
9898

99-
// As a rule, we don't compile hidden files for now. If we encounter one,
100-
// just return.
101-
if (fileSearch.isHiddenFile(outputFilePath)) return
99+
// Skip compiling hidden files unless includeHidden flag is enabled
100+
if (fileSearch.isHiddenFile(file) && !lessWatchCompilerUtilsModule.config.includeHidden) return
102101

103102
var enableJsFlag = lessWatchCompilerUtilsModule.config.enableJs ? ' --js' : '';
104103
var minifiedFlag = lessWatchCompilerUtilsModule.config.minified ? ' -x' : '';

test/lessWatchCompilerUtils.js

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,21 @@ describe('lessWatchCompilerUtils Module API', function () {
111111
};
112112
assert.equal("lessc --math=strict --strict-units=on --include-path=./dir1\;./dir2 \"test.less\" \"testFolder/test.css\"", lessWatchCompilerUtils.compileCSS("test.less", true).command);
113113
});
114+
115+
it('should not compile hidden files by default', function () {
116+
lessWatchCompilerUtils.config = {
117+
outputFolder: "testFolder"
118+
};
119+
assert.equal(undefined, lessWatchCompilerUtils.compileCSS("_test.less", true));
120+
});
121+
122+
it('should compile hidden files when includeHidden flag is set', function () {
123+
lessWatchCompilerUtils.config = {
124+
outputFolder: "testFolder",
125+
includeHidden: true
126+
};
127+
assert.equal("lessc \"_test.less\" \"testFolder/_test.css\"", lessWatchCompilerUtils.compileCSS("_test.less", true).command);
128+
});
114129
});
115130
describe('resolveOutputPath()', function () {
116131
// reset config

0 commit comments

Comments
 (0)