From 476214f4b6213cab944f32e925d327c755755aff Mon Sep 17 00:00:00 2001 From: Griffin Smith Date: Wed, 16 Nov 2022 18:17:29 -0500 Subject: [PATCH] Don't set #![deny(warnings)] on the whole crate deny(warnings) is generally considered to be a pretty strong anti-pattern[0] because new warnings can be introduced, either by new versions of rustc or by new versions of dependencies, that the binary author may want to prevent but shouldn't prevent users from building from source. In this case, a newer version of `chrono` deprecated `NaiveDateTime::from_timestamp`, which ended up breaking my CI pipeline because josh is no longer able to build. Generally, instead, it's better practice to deny *specific* warnings, or build with `-D warnings` in CI. [0]: https://rust-unofficial.github.io/patterns/anti_patterns/deny-warnings.html --- src/lib.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/lib.rs b/src/lib.rs index 0cfa62486..c32202130 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -1,4 +1,3 @@ -#![deny(warnings)] #![warn(unused_extern_crates)] #[macro_export]