-
Notifications
You must be signed in to change notification settings - Fork 27
make it build on M2 macOS 13 (probably M1 and 10.13) #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks! |
|
However, I can't merge, @jpcima didn't gave me a permission to this repo, and now I can't contact him: he seems disappeared for a while... (After September 2022, he disappeared) |
|
I guess, I'll fork this repo to apply/receive fixes until the wonder happens and @jpcima comes back. |
|
I have my own fork with a handful of improvements and migrations to JUCE7 there. If it's looking easier to maintain I can give you write access and do whatever that does not cost (much). https://github.com/atsushieno/ADLplug-AE/ |
|
Hello! |
|
Anyway, as I am not so experienced in JUCE, I would need some hints at first on how to apply some tweaks like adding UI elements to existing forms, etc. For example, recently I added "channel allocations mode" option that exists on libADLMIDI and libOPNMIDI for a while but it was never binded to ADLPlug until recent time, and I trying to implement that. |
|
I'm neither familiar with juce_gui_basics much (I am one who wants to have it totally eliminated as it's quite insufficient to support international text inputs on Linux) nor ADLplug codebase itself, but looks like those |
|
You can take whatever changes I made to ADLplug-AE, but especially it is NOT backward compatible with ADLplug in terms of how it deals with LV2 parameters etc. which means the plugin state data is essentially incompatible. ADLplug-AE is based on the official JUCE way (also conforms to the best practices from LV2 officials like it's based on Atom) rather than the traditional JUCE LV2 fork. |
I had been trying to build ADLplug/OPNplug on my M2 mac and managed to get it working, so I would share it here.
There was a drawback in the change set though;
midi_keyboard_ex.h/.ccdoes not compile with the latest clang++ from Xcode toolchains (it fails to resolve the class name atJUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR). Looks like it is required only to reducejuce_audio_utils, so I only removed the hack around (exnamespace) and simply added the module to the build as I don't see the reason why it had better be cut. If there is any way to preserve it to still compile fine, then I would bring it back, I do not stick to it.