Build: Fix remaining ESLint violations

Author: mgol

demos/.eslintrc.json

@@ -0,0 +1,5 @@
+{
+	"root": true,
+
+	"extends": "../ui/.eslintrc.json"
+}

demos/bootstrap.js

@@ -1,5 +1,6 @@
 /* globals window, document */
 ( function() {
+"use strict";
 
 // Find the script element
 var scripts = document.getElementsByTagName( "script" );

tests/.eslintrc.json

@@ -10,13 +10,10 @@
 	},
 
 	"rules": {
-		"strict": [ "error", "function" ],
-
-		// The following rule is relaxed due to too many violations:
-		"no-unused-vars": [ "error", { "vars": "all", "args": "after-used" } ],
-
 		// Too many violations:
-		"max-len": "off"
+		"max-len": "off",
+		"no-unused-vars": "off",
+		"strict": "off" // ideally, `[ "error", "function" ]`
 	},
 
 	"globals": {

tests/unit/dialog/methods.js

@@ -69,7 +69,7 @@ QUnit.test( "destroy", function( assert ) {
 	assert.equal( $( ".ui-widget-overlay" ).length, 0, "overlay does not exist" );
 	assert.equal( $( document ).data( "ui-dialog-overlays" ), undefined, "ui-dialog-overlays equals the number of open overlays" );
 
-	element = $( "#dialog1" ).dialog( { modal: true } ),
+	element = $( "#dialog1" ).dialog( { modal: true } );
 	element2 = $( "#dialog2" ).dialog( { modal: true } );
 	assert.equal( $( ".ui-widget-overlay" ).length, 2, "overlays created when dialogs are open" );
 	assert.equal( $( document ).data( "ui-dialog-overlays" ), 2, "ui-dialog-overlays equals the number of open overlays" );

tests/unit/droppable/core.js

@@ -21,7 +21,9 @@ QUnit.test( "element types", function( assert ) {
 		var typeName = typeNames[ i ],
 			el = $( document.createElement( typeName ) ).appendTo( "body" );
 
-		( typeName === "table" && el.append( "<tr><td>content</td></tr>" ) );
+		if ( typeName === "table" ) {
+			el.append( "<tr><td>content</td></tr>" );
+		}
 		el.droppable();
 		testHelper.shouldDrop( assert );
 		el.droppable( "destroy" );

tests/unit/droppable/methods.js

@@ -62,7 +62,7 @@ QUnit.test( "enable", function( assert ) {
 	assert.equal( el.droppable( "option", "disabled" ), false, "disabled option setter" );
 	testHelper.shouldDrop( assert );
 
-	expected = $( "<div></div>" ).droppable(),
+	expected = $( "<div></div>" ).droppable();
 	actual = expected.droppable( "enable" );
 	assert.equal( actual, expected, "enable is chainable" );
 } );

tests/unit/effects/scale.js

@@ -35,8 +35,16 @@ function run( position, v, h, vo, ho ) {
 
 		css[ h ] = 33;
 		css[ v ] = 33;
-		target[ h ] = h === ho ? css[ h ] : ho === "center" ? css[ h ] - 35 : css[ h ] - 70;
-		target[ v ] = v === vo ? css[ v ] : vo === "middle" ? css[ v ] - 35 : css[ v ] - 70;
+		if ( h === ho ) {
+			target[ h ] = css[ h ];
+		} else {
+			target[ h ] = ho === "center" ? css[ h ] - 35 : css[ h ] - 70;
+		}
+		if ( v === vo ) {
+			target[ v ] = css[ v ];
+		} else {
+			target[ v ] = vo === "middle" ? css[ v ] - 35 : css[ v ] - 70;
+		}
 		if ( relative && h === "right" ) {
 			target[ h ] += 70;
 		}

tests/unit/slider/events.js

@@ -125,16 +125,16 @@ QUnit.test( "mouse based interaction part two: when handles overlap", function(
 			start: function( event, ui ) {
 				assert.equal( handles.index( ui.handle ), 0, "leftmost handle activated when overlapping at maximum" );
 			}
-		} ),
-		handles = element.find( ".ui-slider-handle" );
+		} );
+	handles = element.find( ".ui-slider-handle" );
 	handles.eq( 0 ).simulate( "drag", { dx: -10 } );
 	element.slider( "destroy" );
 
 	element = $( "#slider1" )
 		.slider( {
 			values: [ 19, 20 ]
-		} ),
-		handles = element.find( ".ui-slider-handle" );
+		} );
+	handles = element.find( ".ui-slider-handle" );
 	handles.eq( 0 ).simulate( "drag", { dx: 10 } );
 	element.one( "slidestart", function( event, ui ) {
 		assert.equal( handles.index( ui.handle ), 0, "left handle activated if left was moved last" );
@@ -145,8 +145,8 @@ QUnit.test( "mouse based interaction part two: when handles overlap", function(
 	element = $( "#slider1" )
 		.slider( {
 			values: [ 19, 20 ]
-		} ),
-		handles = element.find( ".ui-slider-handle" );
+		} );
+	handles = element.find( ".ui-slider-handle" );
 	handles.eq( 1 ).simulate( "drag", { dx: -10 } );
 	element.one( "slidestart", function( event, ui ) {
 		assert.equal( handles.index( ui.handle ), 1, "right handle activated if right was moved last (#3467)" );
@@ -159,8 +159,8 @@ QUnit.test( "mouse based interaction part two: when handles overlap", function(
 			min: 0,
 			max: 100,
 			values: [ 0, 50 ]
-		} ),
-		handles = element.find( ".ui-slider-handle" );
+		} );
+	handles = element.find( ".ui-slider-handle" );
 
 	element.slider( "option", { values: [ 100, 100 ] } );
 	handles.eq( 0 ).simulate( "drag", { dx: -10 } );

tests/unit/sortable/methods.js

@@ -63,7 +63,7 @@ QUnit.test( "enable", function( assert ) {
 
 	testHelper.sort( assert, $( "li", el )[ 0 ], 0, 44, 2, ".sortable('option', 'disabled', false)" );
 
-	expected = $( "<div></div>" ).sortable(),
+	expected = $( "<div></div>" ).sortable();
 	actual = expected.sortable( "enable" );
 	assert.equal( actual, expected, "enable is chainable" );
 } );

tests/unit/tooltip/helper.js

@@ -14,10 +14,8 @@ define( [
 						timers = jQuery.timers;
 
 					jQuery.fx.stop();
-					var x = false;
 
 					for ( index = timers.length; index--; ) {
-						x = true;
 						timer = timers[ index ];
 						timer.anim.stop();
 						timers.splice( index, 1 );