change exception thrown by Sap::getAttributes() to LogicException when no connection available

Author: jsoumelidis

classes/Sap.php

@@ -94,7 +94,7 @@ public function getFunctionClass(): string
      *
      * @return array
      *
-     * @throws SapConnectionException if no connection is available
+     * @throws LogicException if no connection is available
      */
     public function getAttributes(): array
     {

php_sap.c

@@ -2266,7 +2266,7 @@ PHP_METHOD(Sap, getAttributes)
     int utf8len;
 
     if (NULL == intern->connection) {
-        zend_throw_exception(sap_ce_SapConnectionException, PHP_SAP_NO_CONNECTION, -1);
+        zend_throw_exception(spl_ce_LogicException, PHP_SAP_NO_CONNECTION, -1);
         return;
     }
 

tests/sap_Sap___construct_basic.phpt

@@ -15,7 +15,7 @@ $s = new Sap();
 
 /** test connect() is not called */
 try { $s->getAttributes(); }
-catch (SapConnectionException $e) {
+catch (LogicException $e) {
 	echo $e->getMessage(), PHP_EOL;
 }
 
@@ -24,7 +24,7 @@ $s = new Sap(null);
 
 /** test connect() is not called */
 try { $s->getAttributes(); }
-catch (SapConnectionException $e) {
+catch (LogicException $e) {
 	echo $e->getMessage(), PHP_EOL;
 }
 

tests/sap_Sap_getAttributes_error.phpt

@@ -5,7 +5,7 @@ Sap::getAttributes error behavior
 $s = new Sap();
 
 try { $s->getAttributes(); }
-catch (SapConnectionException $e) {
+catch (LogicException $e) {
 	echo $e->getMessage(), PHP_EOL;
 }
 ?>