Merge branch 'master' into nothing

Author: pfitzseb

.github/workflows/jlpkgbutler-butler-workflow.yml

@@ -14,7 +14,7 @@ jobs:
     name: "Run Package Butler"
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - uses: davidanthoff/julia-pkgbutler@releases/v1
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/jlpkgbutler-ci-master-workflow.yml

@@ -12,15 +12,15 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        julia-version: ['1.0', '1.1', '1.2', '1.3', '1.4', '1.5', '1.6', '1.7', '1.8']
+        julia-version: ['1.0', '1.1', '1.2', '1.3', '1.4', '1.5', '1.6', '1.7', '1.8', '1.9']
         julia-arch: [x64, x86]
         os: [ubuntu-latest, windows-latest, macOS-latest]
         exclude:
           - os: macOS-latest
             julia-arch: x86
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - uses: julia-actions/setup-julia@v1
         with:
           version: ${{ matrix.julia-version }}
@@ -32,7 +32,7 @@ jobs:
         env:
           PYTHON: ""
       - uses: julia-actions/julia-processcoverage@v1
-      - uses: codecov/codecov-action@v2
+      - uses: codecov/codecov-action@v3
         with:
           files: ./lcov.info
           flags: unittests

.github/workflows/jlpkgbutler-ci-pr-workflow.yml

@@ -9,15 +9,15 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        julia-version: ['1.0', '1.1', '1.2', '1.3', '1.4', '1.5', '1.6', '1.7', '1.8']
+        julia-version: ['1.0', '1.1', '1.2', '1.3', '1.4', '1.5', '1.6', '1.7', '1.8', '1.9']
         julia-arch: [x64, x86]
         os: [ubuntu-latest, windows-latest, macOS-latest]
         exclude:
           - os: macOS-latest
             julia-arch: x86
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - uses: julia-actions/setup-julia@v1
         with:
           version: ${{ matrix.julia-version }}
@@ -29,7 +29,7 @@ jobs:
         env:
           PYTHON: ""
       - uses: julia-actions/julia-processcoverage@v1
-      - uses: codecov/codecov-action@v2
+      - uses: codecov/codecov-action@v3
         with:
           files: ./lcov.info
           flags: unittests

.github/workflows/jlpkgbutler-codeformat-pr-workflow.yml

@@ -11,7 +11,7 @@ jobs:
   format:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - uses: julia-actions/julia-codeformat@releases/v1
       - name: Create Pull Request
         uses: peter-evans/create-pull-request@v3

.github/workflows/jlpkgbutler-docdeploy-workflow.yml

@@ -13,7 +13,7 @@ jobs:
   docdeploy:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - uses: julia-actions/julia-buildpkg@v1
         env:
           PYTHON: ""

src/interface.jl

@@ -1,8 +1,9 @@
 function setup_server(env = dirname(SymbolServer.Pkg.Types.Context().env.project_file), depot = first(SymbolServer.Pkg.depots()), cache = joinpath(dirname(pathof(SymbolServer)), "..", "store"))
     server = StaticLint.FileServer()
     ssi = SymbolServerInstance(depot, cache)
-    _, server.symbolserver = SymbolServer.getstore(ssi, env)
-    server.symbol_extends  = SymbolServer.collect_extended_methods(server.symbolserver)
+    _, symbols = SymbolServer.getstore(ssi, env)
+    extended_methods = SymbolServer.collect_extended_methods(symbols)
+    server.external_env = ExternalEnv(symbols, extended_methods, Symbol[])
     server
 end
 

src/references.jl

@@ -203,8 +203,8 @@ function resolve_getfield(x::EXPR, parent_type::EXPR, state::State)::Bool
         if CSTParser.defines_module(parent_type) && scopeof(parent_type) isa Scope
             resolved = resolve_ref(x, scopeof(parent_type), state)
         elseif CSTParser.defines_struct(parent_type)
-            if scopehasbinding(scopeof(parent_type), valof(x))
-                setref!(x, scopeof(parent_type).names[valof(x)])
+            if scopehasbinding(scopeof(parent_type), valofid(x))
+                setref!(x, scopeof(parent_type).names[valofid(x)])
                 resolved = true
             end
         end

test/runtests.jl

@@ -646,12 +646,17 @@ f(arg) = arg
         name
         func
         func1
+        struct AnyType
+            var"anything"
+        end
+        anything(x::AnyType) = x.var"anything"
         """)
                 StaticLint.collect_hints(cst, getenv(server.files[""], server))
                 @test all(n in keys(cst.meta.scope.names) for n in ("name", "func"))
                 @test StaticLint.hasref(cst[4])
                 @test StaticLint.hasref(cst[5])
                 @test StaticLint.hasref(cst[6])
+                @test cst.args[8].args[2].args[1].args[2].args[1] in bindingof(cst.args[7].args[3].args[1]).refs
             end
         end
     end