Skip to content

Commit b5eef26

Browse files
committed
refactor: using stringData field to setup secret
This makes the code simpler and lets k8s encode the data
1 parent 55bbdb6 commit b5eef26

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

binderhub/build.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
Contains build of a docker image from a git repository.
33
"""
44

5-
import base64
65
import datetime
76
import json
87
import os
@@ -383,13 +382,8 @@ def submit(self):
383382

384383
env = []
385384
if self.git_credentials:
386-
secret_content = base64.b64encode(
387-
self.git_credentials.encode("utf-8")
388-
).decode("utf-8")
389-
data = {"credentials": secret_content}
390-
391385
secret = client.V1Secret()
392-
secret.data = data
386+
secret.string_data = {"credentials": self.git_credentials}
393387
secret.metadata = {"name": self.name}
394388
secret.type = "Opaque"
395389

0 commit comments

Comments
 (0)