Skip to content

Check if query names are unique across jobs #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check if query names are unique across jobs #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions exporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package main
import (
"context"
"fmt"
"strings"

"cloud.google.com/go/cloudsqlconn"
"cloud.google.com/go/cloudsqlconn/mysql/mysql"
Expand Down Expand Up @@ -36,6 +37,22 @@ func NewExporter(logger log.Logger, configFile string) (*Exporter, error) {
return nil, err
}

// Validate config file before, this will otherwise break Prometheus metrics ("was collected before with the same name and label values")
uniqueQueries := make(map[string]struct{})
var duplicateQueries []string
for _, job := range cfg.Jobs {
for _, query := range job.Queries {
if _, ok := uniqueQueries[query.Name]; ok {
duplicateQueries = append(duplicateQueries, query.Name)
Copy link

Copilot AI Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate query names may be appended multiple times if encountered repeatedly, resulting in redundant entries in the error message.

Suggested change
duplicateQueries = append(duplicateQueries, query.Name)
if _, added := addedDuplicates[query.Name]; !added {
duplicateQueries = append(duplicateQueries, query.Name)
addedDuplicates[query.Name] = struct{}{}
}

Copilot uses AI. Check for mistakes.
continue
}
uniqueQueries[query.Name] = struct{}{}
}
}
if len(duplicateQueries) > 0 {
return nil, fmt.Errorf("invalid config file, query name is not unique across jobs: %v", strings.Join(duplicateQueries, ", "))
}

var queryDurationHistogramBuckets []float64
if len(cfg.Configuration.HistogramBuckets) == 0 {
queryDurationHistogramBuckets = DefaultQueryDurationHistogramBuckets
Expand Down
Loading