Fix linter issues

Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <[email protected]>

Author: juanluisvaladas

protocol/ssh/signals.go

@@ -57,8 +57,8 @@ func termSizeWNCH() []byte {
 		binary.BigEndian.PutUint32(size, 40)
 		binary.BigEndian.PutUint32(size[4:], 80)
 	} else {
-		binary.BigEndian.PutUint32(size, uint32(cols))
-		binary.BigEndian.PutUint32(size[4:], uint32(rows))
+		binary.BigEndian.PutUint32(size, uint32(cols))     // #nosec G115 -- ignore "integer overflow conversion int -> uint32"
+		binary.BigEndian.PutUint32(size[4:], uint32(rows)) // #nosec G115 -- ignore "integer overflow conversion int -> uint32"
 	}
 
 	return size

remotefs/posixfs.go

@@ -154,7 +154,8 @@ func posixBitsToFileMode(bits int64) fs.FileMode {
 	}
 
 	// Mapping permission bits
-	mode |= fs.FileMode(bits & 0o777) // Owner, group, and other permissions
+	// Owner, group, and other permissions
+	mode |= fs.FileMode(bits & 0o777) // #nosec G115 -- ignore "integer overflow conversion int64 -> uint64"
 
 	// Mapping special permission bits
 	if bits&0o4000 != 0 { // Set-user-ID

remotefs/withname.go

@@ -3,14 +3,22 @@ package remotefs
 import "io/fs"
 
 const (
-	OpClose    = "close"     // OpClose Close operation
-	OpOpen     = "open"      // OpOpen Open operation
-	OpRead     = "read"      // OpRead Read operation
-	OpSeek     = "seek"      // OpSeek Seek operation
-	OpStat     = "stat"      // OpStat Stat operation
-	OpWrite    = "write"     // OpWrite Write operation
-	OpCopyTo   = "copy-to"   // OpCopyTo CopyTo operation
-	OpCopyFrom = "copy-from" // OpCopyFrom CopyFrom operation
+	// OpClose Close operation.
+	OpClose = "close"
+	// OpOpen Open operation.
+	OpOpen = "open"
+	// OpRead Read operation.
+	OpRead = "read"
+	// OpSeek Seek operation.
+	OpSeek = "seek"
+	// OpStat Stat operation.
+	OpStat = "stat"
+	// OpWrite Write operation.
+	OpWrite = "write"
+	// OpCopyTo CopyTo operation.
+	OpCopyTo = "copy-to"
+	// OpCopyFrom CopyFrom operation.
+	OpCopyFrom = "copy-from"
 )
 
 type withPath struct {

sshconfig/printer.go

@@ -128,9 +128,9 @@ func (p *printer) number(key string) (string, bool) {
 	}
 	if field, err := p.get(key, reflect.Uint); err == nil {
 		if key == "StreamLocalBindMask" {
-			return "0" + strconv.FormatInt(int64(field.Uint()), 8), true
+			return "0" + strconv.FormatInt(int64(field.Uint()), 8), true // #nosec G115 -- ignore "integer overflow conversion int64 -> uint64"
 		}
-		return strconv.FormatInt(int64(field.Uint()), 10), true
+		return strconv.FormatInt(int64(field.Uint()), 10), true // #nosec G115 -- ignore "integer overflow conversion int64 -> uint64"
 	}
 	return "", false
 }

sshconfig/set.go

@@ -1125,7 +1125,7 @@ func (s *Setter) expandToken(token string) (string, error) { //nolint:cyclop
 
 		if f, err := s.get("Port", reflect.Uint); err == nil {
 			if f.Uint() > 0 {
-				return strconv.Itoa(int(f.Uint())), nil
+				return strconv.Itoa(int(f.Uint())), nil // #nosec G115 -- ignore "integer overflow conversion uint64 -> int"
 			}
 		}
 		if f, err := s.get("Port", reflect.String); err == nil {
@@ -1349,7 +1349,7 @@ func (s *Setter) matchesHost(conditions ...string) (bool, error) {
 // matchesMatch checks if the Match directive conditions are met.
 func (s *Setter) matchesMatch(conditions ...string) (bool, error) { //nolint:funlen,cyclop // TODO extract functions
 	log.Trace(context.Background(), "matching Match directive", "conditions", conditions)
-	for i := range len(conditions) {
+	for i := range conditions {
 		condition := conditions[i]
 		log.Trace(context.Background(), "matching Match directive", "condition", condition)
 		var negate bool
@@ -1607,7 +1607,7 @@ func (s *Setter) canonicalizeMaxDots() int {
 	if md, err := s.get("CanonicalizeMaxDots", reflect.Int); err == nil {
 		return int(md.Int())
 	} else if md, err := s.get("CanonicalizeMaxDots", reflect.Uint); err == nil {
-		return int(md.Uint())
+		return int(md.Uint()) // #nosec G115 -- ignore "integer overflow conversion int64 -> uint64"
 	}
 	return 1
 }