Skip to content

Commit eb2654b

Browse files
committed
fix up log msg
Signed-off-by: Karol Szwaj <[email protected]> On-behalf-of: @SAP [email protected]
1 parent 3f499ab commit eb2654b

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

examples/initializingworkspaces/README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,17 +22,14 @@ Observe the controller reconciling every logical cluster and creating the `kcp-i
2222

2323
```sh
2424
2025-06-23T16:33:24+02:00 INFO Starting to initialize cluster {"controller": "kcp-initializer-controller", "controllerGroup": "core.kcp.io", "controllerKind": "LogicalCluster", "reconcileID": "f4149561-a2a0-40bf-bcdc-b124a3042d6f", "cluster": "10gwnu7yxzk58m2e"}
25-
2025-06-23T16:33:24+02:00 INFO Created ConfigMap {"controller": "kcp-initializer-controller", "controllerGroup": "core.kcp.io", "controllerKind": "LogicalCluster", "reconcileID": "f4149561-a2a0-40bf-bcdc-b124a3042d6f", "cluster": "10gwnu7yxzk58m2e", "name": "kcp-initializer-cm", "uuid": "e1da25d0-fb6a-4486-953b-d5a3772c4241"}
2625
2025-06-23T16:33:24+02:00 INFO Reconciling ConfigMap {"controller": "kcp-initializer-controller", "controllerGroup": "core.kcp.io", "controllerKind": "LogicalCluster", "reconcileID": "f4149561-a2a0-40bf-bcdc-b124a3042d6f", "cluster": "10gwnu7yxzk58m2e", "name": "kcp-initializer-cm", "uuid": "e1da25d0-fb6a-4486-953b-d5a3772c4241"}
2726
2025-06-23T16:33:25+02:00 INFO Removed initializer from LogicalCluster status {"controller": "kcp-initializer-controller", "controllerGroup": "core.kcp.io", "controllerKind": "LogicalCluster", "reconcileID": "f4149561-a2a0-40bf-bcdc-b124a3042d6f", "cluster": "10gwnu7yxzk58m2e", "name": "cluster", "uuid": "64b04afc-d04d-4842-8447-892491aec467"}
2827
2025-06-23T16:33:25+02:00 INFO Starting to initialize cluster {"controller": "kcp-initializer-controller", "controllerGroup": "core.kcp.io", "controllerKind": "LogicalCluster", "reconcileID": "f55046e7-36c6-40ee-a043-81e8891b5f37", "cluster": "2vjb557hetgz77w0"}
2928
2025-06-23T16:33:25+02:00 INFO kcp-initializing-workspaces-provider disengaging initializing workspace {"cluster": "10gwnu7yxzk58m2e"}
30-
2025-06-23T16:33:25+02:00 INFO Created ConfigMap {"controller": "kcp-initializer-controller", "controllerGroup": "core.kcp.io", "controllerKind": "LogicalCluster", "reconcileID": "f55046e7-36c6-40ee-a043-81e8891b5f37", "cluster": "2vjb557hetgz77w0", "name": "kcp-initializer-cm", "uuid": "0a3d3f60-1c3e-4a45-bee5-29db902a062b"}
3129
2025-06-23T16:33:25+02:00 INFO Reconciling ConfigMap {"controller": "kcp-initializer-controller", "controllerGroup": "core.kcp.io", "controllerKind": "LogicalCluster", "reconcileID": "f55046e7-36c6-40ee-a043-81e8891b5f37", "cluster": "2vjb557hetgz77w0", "name": "kcp-initializer-cm", "uuid": "0a3d3f60-1c3e-4a45-bee5-29db902a062b"}
3230
2025-06-23T16:33:25+02:00 INFO Removed initializer from LogicalCluster status {"controller": "kcp-initializer-controller", "controllerGroup": "core.kcp.io", "controllerKind": "LogicalCluster", "reconcileID": "f55046e7-36c6-40ee-a043-81e8891b5f37", "cluster": "2vjb557hetgz77w0", "name": "cluster", "uuid": "994fba1b-7c79-4866-9408-c4a73cfa7351"}
3331
2025-06-23T16:33:25+02:00 INFO Starting to initialize cluster {"controller": "kcp-initializer-controller", "controllerGroup": "core.kcp.io", "controllerKind": "LogicalCluster", "reconcileID": "4371aedd-9405-45c6-b8c5-43399154c457", "cluster": "7zb1jyl4f5y4h65p"}
3432
2025-06-23T16:33:25+02:00 INFO kcp-initializing-workspaces-provider disengaging initializing workspace {"cluster": "2vjb557hetgz77w0"}
35-
2025-06-23T16:33:25+02:00 INFO Created ConfigMap {"controller": "kcp-initializer-controller", "controllerGroup": "core.kcp.io", "controllerKind": "LogicalCluster", "reconcileID": "4371aedd-9405-45c6-b8c5-43399154c457", "cluster": "7zb1jyl4f5y4h65p", "name": "kcp-initializer-cm", "uuid": "8a922d1a-04a3-4848-b1e5-e90d2f5405d7"}
3633
2025-06-23T16:33:25+02:00 INFO Reconciling ConfigMap {"controller": "kcp-initializer-controller", "controllerGroup": "core.kcp.io", "controllerKind": "LogicalCluster", "reconcileID": "4371aedd-9405-45c6-b8c5-43399154c457", "cluster": "7zb1jyl4f5y4h65p", "name": "kcp-initializer-cm", "uuid": "8a922d1a-04a3-4848-b1e5-e90d2f5405d7"}
3734
2025-06-23T16:33:25+02:00 INFO Removed initializer from LogicalCluster status {"controller": "kcp-initializer-controller", "controllerGroup": "core.kcp.io", "controllerKind": "LogicalCluster", "reconcileID": "4371aedd-9405-45c6-b8c5-43399154c457", "cluster": "7zb1jyl4f5y4h65p", "name": "cluster", "uuid": "3f160828-89af-4ee7-ba5f-f65bd21d90da"}
3835
2025-06-23T16:33:25+02:00 INFO kcp-initializing-workspaces-provider disengaging initializing workspace {"cluster": "7zb1jyl4f5y4h65p"}

examples/initializingworkspaces/main.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -121,20 +121,17 @@ func main() {
121121
"test-data": "example-value",
122122
},
123123
}
124+
log.Info("Reconciling ConfigMap", "name", s.Name, "uuid", s.UID)
124125
if err := client.Create(ctx, s); err != nil {
125126
return reconcile.Result{}, fmt.Errorf("failed to create configmap: %w", err)
126127
}
127-
log.Info("Created ConfigMap", "name", s.Name, "uuid", s.UID)
128128
// Remove the initializer from the logical cluster status
129129
// so that it won't be processed again.
130-
131130
initializerName := corev1alpha1.LogicalClusterInitializer(initializerName)
132131
if !slices.Contains(lc.Status.Initializers, initializerName) {
133132
log.Info("Initializer already absent, skipping patch")
134133
return reconcile.Result{}, nil
135134
}
136-
log.Info("Reconciling ConfigMap", "name", s.Name, "uuid", s.UID)
137-
138135
patch := ctrlclient.MergeFrom(lc.DeepCopy())
139136
lc.Status.Initializers = initialization.EnsureInitializerAbsent(initializerName, lc.Status.Initializers)
140137
if err := client.Status().Patch(ctx, lc, patch); err != nil {

0 commit comments

Comments
 (0)