Merge pull request #210 from JenySadadia/restructure-issues-cmd

Restructure `issues` commands

Author: aliceinwire

kcidev/libs/dashboard.py

@@ -13,7 +13,9 @@
 
 def _dashboard_request(func):
     @wraps(func)
-    def wrapper(endpoint, params, use_json, body=None, max_retries=3):
+    def wrapper(
+        endpoint, params, use_json, body=None, max_retries=3, error_verbose=True
+    ):
         base_url = urllib.parse.urljoin(DASHBOARD_API, endpoint)
         url = "{}?{}".format(base_url, urllib.parse.urlencode(params))
         retries = 0
@@ -53,11 +55,12 @@ def wrapper(endpoint, params, use_json, body=None, max_retries=3):
                 logging.debug(f"Response data size: {len(json.dumps(data))} bytes")
 
                 if "error" in data:
-                    logging.error(f"API returned error: {data.get('error')}")
-                    if use_json:
-                        kci_msg(data)
-                    else:
-                        kci_msg("json error: " + str(data["error"]))
+                    if error_verbose:
+                        logging.error(f"API returned error: {data.get('error')}")
+                        if use_json:
+                            kci_msg(data)
+                        else:
+                            kci_msg("json error: " + str(data["error"]))
                     raise click.ClickException(data.get("error"))
 
                 logging.info(f"Successfully completed {func.__name__} request")
@@ -81,7 +84,7 @@ def dashboard_api_post(endpoint, params, use_json, body, max_retries=3):
 
 
 @_dashboard_request
-def dashboard_api_fetch(endpoint, params, use_json, max_retries=3):
+def dashboard_api_fetch(endpoint, params, use_json, max_retries=3, error_verbose=True):
     return requests.get(endpoint)
 
 
@@ -115,7 +118,16 @@ def dashboard_fetch_commits_history(origin, giturl, branch, commit, use_json):
 
 
 def dashboard_fetch_builds(
-    origin, giturl, branch, commit, arch, tree, start_date, end_date, use_json
+    origin,
+    giturl,
+    branch,
+    commit,
+    arch,
+    tree,
+    start_date,
+    end_date,
+    use_json,
+    error_verbose=True,
 ):
     endpoint = f"tree/{commit}/builds"
     params = {
@@ -136,7 +148,7 @@ def dashboard_fetch_builds(
     logging.debug(
         f"Filters: arch={arch}, tree={tree}, start_date={start_date}, end_date={end_date}"
     )
-    return dashboard_api_fetch(endpoint, params, use_json)
+    return dashboard_api_fetch(endpoint, params, use_json, error_verbose=error_verbose)
 
 
 def dashboard_fetch_boots(
@@ -150,6 +162,7 @@ def dashboard_fetch_boots(
     end_date,
     use_json,
     boot_origin,
+    error_verbose=True,
 ):
     endpoint = f"tree/{commit}/boots"
     params = {
@@ -172,7 +185,7 @@ def dashboard_fetch_boots(
     logging.debug(
         f"Filters: arch={arch}, tree={tree}, start_date={start_date}, end_date={end_date}"
     )
-    return dashboard_api_fetch(endpoint, params, use_json)
+    return dashboard_api_fetch(endpoint, params, use_json, error_verbose=error_verbose)
 
 
 def dashboard_fetch_tests(
@@ -283,23 +296,24 @@ def dashboard_fetch_hardware_tests(name, origin, use_json):
     )
 
 
-def dashboard_fetch_build_issues(build_id, use_json):
+def dashboard_fetch_build_issues(build_id, use_json, error_verbose):
     endpoint = f"build/{build_id}/issues"
     logging.info(f"Fetching build issues for build ID: {build_id}")
-    return dashboard_api_fetch(endpoint, {}, use_json)
+    return dashboard_api_fetch(endpoint, {}, use_json, error_verbose=error_verbose)
 
 
-def dashboard_fetch_boot_issues(test_id, use_json):
+def dashboard_fetch_boot_issues(test_id, use_json, error_verbose):
     endpoint = f"test/{test_id}/issues"
     logging.info(f"Fetching test issues for test ID: {test_id}")
-    return dashboard_api_fetch(endpoint, {}, use_json)
+    return dashboard_api_fetch(endpoint, {}, use_json, error_verbose=error_verbose)
 
 
 def dashboard_fetch_issue_list(origin, days, use_json):
     params = {
-        "filter_origin": origin,
         "interval_in_days": days,
     }
+    if origin:
+        params["filter_origin"] = origin
     logging.info(f"Fetching issue list for origin: {origin}")
     return dashboard_api_fetch("issue/", params, use_json)
 
@@ -309,16 +323,20 @@ def dashboard_fetch_issue(issue_id, use_json):
     return dashboard_api_fetch(f"issue/{issue_id}", {}, use_json)
 
 
-def dashboard_fetch_issue_builds(origin, issue_id, use_json):
+def dashboard_fetch_issue_builds(origin, issue_id, use_json, error_verbose=True):
     logging.info(f"Fetching builds for issue ID: {issue_id}")
-    params = {"filter_origin": origin}
-    return dashboard_api_fetch(f"issue/{issue_id}/builds", params, use_json)
+    params = {"filter_origin": origin} if origin else {}
+    return dashboard_api_fetch(
+        f"issue/{issue_id}/builds", params, use_json, error_verbose=error_verbose
+    )
 
 
-def dashboard_fetch_issue_tests(origin, issue_id, use_json):
+def dashboard_fetch_issue_tests(origin, issue_id, use_json, error_verbose=True):
     logging.info(f"Fetching tests for issue ID: {issue_id}")
-    params = {"filter_origin": origin}
-    return dashboard_api_fetch(f"issue/{issue_id}/tests", params, use_json)
+    params = {"filter_origin": origin} if origin else {}
+    return dashboard_api_fetch(
+        f"issue/{issue_id}/tests", params, use_json, error_verbose=error_verbose
+    )
 
 
 def dashboard_fetch_issues_extra(issues, use_json):