Skip to content

config: pipeline: add build job for x86-drm fragment #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vigneshraman wants to merge 1 commit into from
Closed

config: pipeline: add build job for x86-drm fragment #1030

vigneshraman wants to merge 1 commit into from

Conversation

@vigneshraman
Copy link
Contributor

@vigneshraman vigneshraman commented Feb 20, 2025

No description provided.

@staging-kernelci-org staging-kernelci-org force-pushed the staging.kernelci.org branch 2 times, most recently from 1fc6819 to ce5b8da Compare February 20, 2025 11:43
@vigneshraman vigneshraman changed the base branch from staging.kernelci.org to main February 20, 2025 12:32
nuclearcat
nuclearcat requested changes Feb 21, 2025
View reviewed changes
Copy link
Member

@nuclearcat nuclearcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you improve commit a bit, something like "Add DRM variant of kernel build", so it will be visible from PR and commit description what it is about exactly

@vigneshraman vigneshraman marked this pull request as draft February 24, 2025 06:57
@vigneshraman
Copy link
Contributor Author

vigneshraman commented Feb 24, 2025

Can you improve commit a bit, something like "Add DRM variant of kernel build", so it will be visible from PR and commit description what it is about exactly

Sure. I added it for testing purpose. Once I test will amend the commit message.

@vigneshraman
Copy link
Contributor Author

vigneshraman commented Mar 4, 2025

@nuclearcat, I see this error,

root@6dbe18c5ce96:~# kci-dev checkout --giturl https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git --branch master --commit 334426094588f8179fe175a09ecc887ff0c75758 --job-filter kbuild-gcc-12-x86-drm
API response error code: 404
{'message': 'Job kbuild-gcc-12-x86-drm not found'}
Failed to trigger checkout

Are these changes pulled in staging?
#1030
kernelci/kernelci-core#2809

@vigneshraman vigneshraman force-pushed the wip/vignesh/add-drm-fragment branch from 2c13adb to a94b780 Compare March 4, 2025 13:34
@nuclearcat
Copy link
Member

nuclearcat commented Mar 4, 2025

As discussed in chat, there was merge conflict during staging run.

@vigneshraman
Copy link
Contributor Author

vigneshraman commented Mar 5, 2025

@nuclearcat, for the drm config the build nodeid is not created. Is something missing?

root@6dbe18c5ce96:~# kci-dev checkout --giturl https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git --branch master --commit 334426094588f8179fe175a09ecc887ff0c75758 --job-filter kbuild-gcc-12-x86-drm
OK
treeid: cebd4862266e4919aa11457814d72bd62ec51a82a8acce01e436dc5ce1e5e7ae
checkout_nodeid: 67c7f7c7708ae0ad775b3745

root@6dbe18c5ce96:~# kci-dev watch --nodeid 67c7f7c7708ae0ad775b3745
job_filter: checkout
PASS branch checkout - node_id:67c7f7c7708ae0ad775b3745 (2025-03-05T07:17:31.580000)

root@6dbe18c5ce96:~# kci-dev maestro-results --nodes --filter parent=67c7f7c7708ae0ad775b3745 --filter kind=kbuild --field state --field id --field name
root@6dbe18c5ce96:~#

@nuclearcat
Copy link
Member

nuclearcat commented Mar 5, 2025

I dont see this fragment in staging: https://github.com/kernelci/kernelci-pipeline/blob/staging.kernelci.org/config/pipeline.yaml

@vigneshraman vigneshraman force-pushed the wip/vignesh/add-drm-fragment branch from a94b780 to 2597af9 Compare March 7, 2025 08:26
@vigneshraman
config: pipeline: add build job for x86-drm fragment
d313c9b 
Add a build job for the x86-drm fragment, which includes configurations
needed for VKMS tests.

Signed-off-by: Vignesh Raman <[email protected]>
@vigneshraman vigneshraman force-pushed the wip/vignesh/add-drm-fragment branch from 2597af9 to d313c9b Compare March 11, 2025 07:45
@vigneshraman vigneshraman changed the title config: pipeline: add drm config: pipeline: add build job for x86-drm fragment Mar 11, 2025
@vigneshraman vigneshraman marked this pull request as ready for review March 11, 2025 07:45
@vigneshraman
Copy link
Contributor Author

vigneshraman commented Mar 11, 2025

@nuclearcat, this is ready for review and merge. Thanks.

@vigneshraman
Copy link
Contributor Author

vigneshraman commented Aug 14, 2025

This is not required for the kci-gitlab v3 now since we build the kernel in kci-gitlab itself. The drm config PR kernelci/kernelci-core#2809 has already been closed. So closing this also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nuclearcat nuclearcat nuclearcat requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vigneshraman @nuclearcat