ExpressSessionManager

Fixes session item retrieval to preserve original data type

Updates the Express session store to correctly return items that are not split into multiple parts.

Previously, all session items were reassembled as strings upon retrieval, causing objects and other non-string types to be incorrectly converted. This change ensures that if an item is stored as a single entry, its original data type is preserved.

Author: dtoxvanilla1991

lib/sessionManager/stores/expressStore.test.ts

@@ -148,7 +148,7 @@ describe("ExpressStore", () => {
       await sessionManager.setSessionItem(StorageKeys.nonce, obj);
       expect(req.session![`${keyPrefix}nonce0`]).toEqual(obj);
       const value = await sessionManager.getSessionItem(StorageKeys.nonce);
-      expect(value).toEqual("[object Object]"); // Because getSessionItem always reassembles as string
+      expect(value).toEqual(obj); // Should return the original object
     });
   });
 });

lib/sessionManager/stores/expressStore.ts

@@ -53,6 +53,13 @@ export class ExpressStore<V extends string = StorageKeys>
     if (this.req.session![`${baseKey}0`] === undefined) {
       return null;
     }
+    
+    // if under settingConfig maxLength - return as-is
+    if (this.req.session![`${baseKey}1`] === undefined) {
+      return this.req.session![`${baseKey}0`];
+    }
+    
+    // Multiple items exist, concatenate them as strings (for split strings)
     let itemValue = "";
     let index = 0;
     let key = `${baseKey}${index}`;