Merge pull request #45 from sgraupmann/new_aws_resource_types

 Added support for a couple resource types.

Author: kishaningithub

pkg/convertor.go

@@ -2,9 +2,10 @@ package tfimportgen
 
 import (
 	"fmt"
-	"github.com/kishaningithub/tf-import-gen/pkg/internal/parser"
 	"slices"
 	"strings"
+
+	"github.com/kishaningithub/tf-import-gen/pkg/internal/parser"
 )
 
 func computeTerraformImportForResource(resource parser.TerraformResource) TerraformImport {
@@ -58,6 +59,8 @@ func computeResourceID(resource parser.TerraformResource) string {
 		return fmt.Sprintf("%s/%s", v("function_name"), v("statement_id"))
 	case "aws_security_group_rule":
 		return computeResourceIDForAWSSecurityGroupRole(resource)
+	case "aws_network_acl_rule":
+		return computeResourceIdForAWSNetworkACLRule(resource)
 	case "aws_api_gateway_resource", "aws_api_gateway_deployment":
 		return fmt.Sprintf("%s/%s", v("rest_api_id"), v("id"))
 	case "aws_api_gateway_stage":
@@ -76,6 +79,8 @@ func computeResourceID(resource parser.TerraformResource) string {
 		return fmt.Sprintf("%s|%s", v("plan_id"), v("id"))
 	case "aws_vpc_endpoint_route_table_association":
 		return fmt.Sprintf("%s/%s", v("vpc_endpoint_id"), v("route_table_id"))
+	case "aws_vpc_endpoint_subnet_association":
+		return fmt.Sprintf("%s/%s", v("vpc_endpoint_id"), v("subnet_id"))
 	case "aws_cognito_user_pool_client":
 		return fmt.Sprintf("%s/%s", v("user_pool_id"), v("id"))
 	case "aws_ecs_cluster":
@@ -220,6 +225,14 @@ func computeResourceIDForAWSSecurityGroupRole(resource parser.TerraformResource)
 	return resourceID
 }
 
+func computeResourceIdForAWSNetworkACLRule(resource parser.TerraformResource) string {
+	networkACLId := fmt.Sprint(resource.AttributeValues["network_acl_id"])
+	ruleNumber := fmt.Sprint(resource.AttributeValues["rule_number"])
+	protocol := fmt.Sprint(resource.AttributeValues["protocol"])
+	egress := fmt.Sprint(resource.AttributeValues["egress"])
+	return fmt.Sprintf("%s:%s:%s:%s", networkACLId, ruleNumber, protocol, egress)
+}
+
 func convertToStrings(source []any) []string {
 	var result []string
 	for _, element := range source {

pkg/convertor_test.go

@@ -1,9 +1,10 @@
 package tfimportgen
 
 import (
+	"testing"
+
 	"github.com/kishaningithub/tf-import-gen/pkg/internal/parser"
 	"github.com/stretchr/testify/require"
-	"testing"
 )
 
 func Test_ComputeTerraformImportForResource(t *testing.T) {
@@ -299,6 +300,40 @@ func Test_ComputeTerraformImportForResource(t *testing.T) {
 				SupportsImport:  true,
 			},
 		},
+		{
+			name: "For aws_vpc_endpoint_subnet_association",
+			terraformResource: parser.TerraformResource{
+				Address: "aws_vpc_endpoint_subnet_association.test",
+				Type:    "aws_vpc_endpoint_subnet_association",
+				AttributeValues: map[string]any{
+					"vpc_endpoint_id": "vpce-12345",
+					"subnet_id":       "subnet-67890",
+				},
+			},
+			expected: TerraformImport{
+				ResourceAddress: "aws_vpc_endpoint_subnet_association.test",
+				ResourceID:      "vpce-12345/subnet-67890",
+				SupportsImport:  true,
+			},
+		},
+		{
+			name: "For aws_network_acl_rule",
+			terraformResource: parser.TerraformResource{
+				Address: "aws_network_acl_rule.test",
+				Type:    "aws_network_acl_rule",
+				AttributeValues: map[string]any{
+					"network_acl_id": "acl-12345",
+					"rule_number":    100,
+					"protocol":       "6",
+					"egress":         false,
+				},
+			},
+			expected: TerraformImport{
+				ResourceAddress: "aws_network_acl_rule.test",
+				ResourceID:      "acl-12345:100:6:false",
+				SupportsImport:  true,
+			},
+		},
 		{
 			name: "For aws_cognito_user_pool_client",
 			terraformResource: parser.TerraformResource{