Skip to content

Commit 420958a

Browse files
committed
WIP: Enable Istio ambient e2e tests
1 parent aa58baf commit 420958a

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

.github/workflows/kind-e2e.yaml

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,7 @@ jobs:
9090
- kourier-tls
9191
- istio
9292
- istio-tls
93-
# Disabled due to flakiness: https://github.com/knative/serving/issues/14637
94-
# - istio-ambient
93+
- istio-ambient
9594
- contour
9695
- gateway_istio
9796
- gateway_contour
@@ -124,11 +123,11 @@ jobs:
124123
namespace-resources: virtualservices
125124
enable-tls: 1
126125

127-
# Disabled due to flakiness: https://github.com/knative/serving/issues/14637
128-
# - ingress: istio-ambient
129-
# namespace-resources: virtualservices
130-
# ingress-class: istio
131-
# ambient: 1
126+
# TODO investigate flakiness: https://github.com/knative/serving/issues/14637
127+
- ingress: istio-ambient
128+
namespace-resources: virtualservices
129+
ingress-class: istio
130+
ambient: 1
132131

133132
- ingress: kourier-tls
134133
ingress-class: kourier
@@ -148,8 +147,8 @@ jobs:
148147
INGRESS_CLASS: ${{ matrix.ingress-class || matrix.ingress }}.ingress.networking.knative.dev
149148
GATEWAY_API_IMPLEMENTATION: ${{ matrix.gateway-api-implementation }}
150149
ENABLE_TLS: ${{ matrix.enable-tls || 0 }}
151-
# Disabled due to flakiness: https://github.com/knative/serving/issues/14637
152-
# AMBIENT: ${{ matrix.ambient || 0 }}
150+
# TODO investigate flakiness: https://github.com/knative/serving/issues/14637
151+
AMBIENT: ${{ matrix.ambient || 0 }}
153152

154153
steps:
155154
- name: setup-go

0 commit comments

Comments
 (0)