Skip to content

get_disaggregated_stats() returns wrong counts #190

New issue
New issue
Open
#191
Open
get_disaggregated_stats() returns wrong counts#190
#191
Assignees
noliveleger
Labels
bughas PRstale?
@jnm

Description

@jnm
jnm
opened on Dec 20, 2018

As discovered by @noliveleger, counter['__submissions__'] contains the count of all submissions, including those where no response was provided. This leads to total_count exceeding the total number of submissions.

formpack/src/formpack/schema/fields.py

Lines 221 to 231 in 0a11fee

def get_disaggregated_stats(self, metrics, top_splitters,
lang=UNSPECIFIED_TRANSLATION, limit=100):
not_provided = 0
provided = 0
for val, counter in metrics.items():
not_provided += counter.pop(None, 0)
provided += counter.pop('__submissions__', 0)
return {
'total_count': not_provided + provided,

Metadata

Metadata

Assignees

Labels

bughas PRstale?

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions