Skip to content

Commit 43c09c2

Browse files
committed
tests/pty.sh: disable 137(C) because it actually tests vi(1)
Testing the behaviour of an external editor, even the standard one, is outside the scope of the ksh regression tests. src/cmd/ksh93/tests/pty.sh: - Disable a test that invoked vi(1) and that failed, either intermittently or consistently, on too many systems because whatever vi(1) is installed locally doesn't write the string "/tmp/" exactly as and/or when expected.
1 parent 5c677a4 commit 43c09c2

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

src/cmd/ksh93/tests/pty.sh

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,13 @@ u #echo save
369369
r history
370370
!
371371

372-
# err_exit #
372+
# Following test is disabled because it fails on too many systems, either intermittently
373+
# or consistently, through no fault of ksh, because vi(1) somehow fails to write "/tmp/"
374+
# as expected. Testing the POSIX compliance of whatever vi(1) the local system happens
375+
# to have is outside the scope of these tests, which are supposed to be testing ksh.
376+
# It is left here for re-enabling temporarily if related changes in ksh need testing.
377+
: <<\end_disabled
378+
# err_(don't count me)_exit #
373379
TMPDIR=/tmp tst $LINENO <<"!"
374380
L POSIX sh 137(C)
375381
@@ -389,6 +395,7 @@ s 400
389395
w :wq
390396
u ^hello world\r?\n$
391397
!
398+
end_disabled
392399

393400
# err_exit #
394401
tst $LINENO <<"!"

0 commit comments

Comments
 (0)